Convert Microsoft.Repl to a .NET Standard library and add pack #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of recent interest in the underlying Microsoft.Repl library, this PR converts it to a .NET Standard 1.3 library (as opposed to .net core 2.1 and 3.0 libraries) to expand its reach, and set it to generate a nuget package.
I picked 1.3 based on the chart here and the fact that .NET Framework 4.6 is the lowest version in mainstream support (I think) listed in that chart. I'm open to suggestions on a different target, though.
The two new package refs were just because of things that weren't natively supported in netstandard1.3, not because of any changes in the library.
I left out the
<PackageProjectUrl>inMicrosoft.Repl.csprojsince we don't have documentation or a website specifically for the Repl and it'll just default to the github url if we leave it out (i think). Let me know if that's not correct.