Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes for 2.0.3 to release #676

Merged
merged 3 commits into from Jan 19, 2018
Merged

Conversation

@prafullbhosale
Copy link
Contributor

@prafullbhosale prafullbhosale commented Jan 19, 2018

Fixes issues:

Changes from release/2.0 are already rebased into the pb/placeholder_2.0.x branch.

These fixes have already been ported to dev.

@natemcmaster natemcmaster requested a review from Eilon Jan 19, 2018
@natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Jan 19, 2018

I didn't review product changes carefully, but I didn't see infrastructure changes, so :shipit: from me.

Once this is merged, can you also update the Scaffolding submodule on the release/2.0 branch in aspnet/Universe? If you're not familiar with git submodules, I've written some instructions here.

@Eilon
Copy link
Member

@Eilon Eilon commented Jan 19, 2018

Unfortunately I don't know this codebase at all so I'm not sure I'll be any good at reviewing the functional changes. But I'm with @natemcmaster that as long as the product changes are good, this is good 😄

@prafullbhosale
Copy link
Contributor Author

@prafullbhosale prafullbhosale commented Jan 19, 2018

The functional changes were already reviewed as part of the PRs mentioned above.
Going to merge this now and update the submodules in universe.

@prafullbhosale prafullbhosale merged commit 8e389be into release/2.0 Jan 19, 2018
1 check passed
1 check passed
license/cla All CLA requirements met.
Details
@prafullbhosale
Copy link
Contributor Author

@prafullbhosale prafullbhosale commented Jan 19, 2018

Don't seem to have write access to Universe. @Eilon could you please provide access?

@natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Jan 19, 2018

I'll take care of updating the submodule.

natemcmaster pushed a commit to aspnet/Universe that referenced this pull request Jan 19, 2018
@natemcmaster natemcmaster deleted the pb/placeholder_2.0.x branch Jan 19, 2018
@Eilon
Copy link
Member

@Eilon Eilon commented Jan 19, 2018

@prafullbhosale you should have access now too, in case you need to do it again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants