From f02fdd935cfddeedd0534e886726b3738b055b7c Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Tue, 19 Oct 2021 16:56:11 -0700 Subject: [PATCH 1/9] add 4.0.0-preview3 release notes --- CHANGELOG.md | 27 +++++++ release-notes/4.0/4.0.0-preview3.md | 121 ++++++++++++++++++++++++++++ release-notes/4.0/4.0.md | 1 + release-notes/4.0/README.md | 1 + 4 files changed, 150 insertions(+) create mode 100644 release-notes/4.0/4.0.0-preview3.md diff --git a/CHANGELOG.md b/CHANGELOG.md index 3767cda1f2..1c5983be26 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,33 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) +## [Preview Release 4.0.0-preview3.x.x] - 2021-10-20 + +This update brings the below changes over the previous release: + +### Breaking changes over preview release v4.0.0-preview2 + +- Dropped support for .NET Core 2.1 [#1272](https://github.com/dotnet/SqlClient/pull/1272) +- Exception will not be thrown if a User ID is provided in the connection string when using `ActiveDirectoryIntegrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) + +### Added + +- Add `GetFieldValue(Async)` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019) + +### Fixed + +- Fixed `FormatException` when opening a connection with event tracing enabled [#1290](https://github.com/dotnet/SqlClient/pull/1290) +- Fixed improper initialization of `ActiveDirectoryAuthenticationProvider` [#1327](https://github.com/dotnet/SqlClient/pull/1327) +- Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1335](https://github.com/dotnet/SqlClient/pull/1335) +- Fixed data corruption issues by reverting changes to async cancellations [#1344](https://github.com/dotnet/SqlClient/pull/1344) +- Fixed performance degradation by reverting changes to MARS state machine [#1357](https://github.com/dotnet/SqlClient/pull/1357) +- Fixed bug where environment variables are ignored when using `ActiveDirectoryDefault` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) + +### Changed + +- Removed attributes for classes used in Microsoft.VSDesigner due to lack of support for Microsoft.Data.SqlClient [#1296](https://github.com/dotnet/SqlClient/pull/1296) +- Disable encryption when connecting to SQL LocalDB [#1312](https://github.com/dotnet/SqlClient/pull/1312) + ## [Preview Release 4.0.0-preview2.21264.2] - 2021-09-21 This update brings the below changes over the previous release: diff --git a/release-notes/4.0/4.0.0-preview3.md b/release-notes/4.0/4.0.0-preview3.md new file mode 100644 index 0000000000..53efcc071d --- /dev/null +++ b/release-notes/4.0/4.0.0-preview3.md @@ -0,0 +1,121 @@ +# Release Notes + +## Microsoft.Data.SqlClient 4.0.0-preview3.x.x released 20 October 2021 + +This update brings the below changes over the previous release: + +### Breaking changes over preview release v4.0.0-preview2 + +- Dropped support for .NET Core 2.1 [#1272](https://github.com/dotnet/SqlClient/pull/1272) +- Exception will not be thrown if a User ID is provided in the connection string when using `ActiveDirectoryIntegrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) + +### Added + +- Add `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019) + +### Fixed + +- Fixed `FormatException` when opening a connection with event tracing enabled [#1290](https://github.com/dotnet/SqlClient/pull/1290) +- Fixed improper initialization of `ActiveDirectoryAuthenticationProvider` [#1327](https://github.com/dotnet/SqlClient/pull/1327) +- Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1335](https://github.com/dotnet/SqlClient/pull/1335) +- Fixed data corruption issues by reverting changes to async cancellations [#1344](https://github.com/dotnet/SqlClient/pull/1344) +- Fixed performance degradation by reverting changes to MARS state machine [#1357](https://github.com/dotnet/SqlClient/pull/1357) +- Fixed bug where environment variables are ignored when using `ActiveDirectoryDefault` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) + +### Changed + +- Removed attributes for classes used in Microsoft.VSDesigner due to lack of support for Microsoft.Data.SqlClient [#1296](https://github.com/dotnet/SqlClient/pull/1296) +- Disable encryption when connecting to SQL LocalDB [#1312](https://github.com/dotnet/SqlClient/pull/1312) + +## New features over preview release v4.0.0-preview2 + +### Remove configurable retry logic safety switch + +The App Context switch "Switch.Microsoft.Data.SqlClient.EnableRetryLogic" will no longer be required to use the configurable retry logic feature. The feature is now supported in production. The default behavior of the feature will continue to be a non-retry policy, which will need to be overridden by client applications to enable retries. + +### `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` types + +`XmlReader`, `TextReader`, `Stream` types are now supported when using `GetFieldValueAsync` and `GetFieldValue`. + +Example usage: + +```cs +using (SqlConnection connection = new SqlConnection(connectionString)) +{ + using (SqlCommand command = new SqlCommand(query, connection)) + { + connection.Open(); + using (SqlDataReader reader = await command.ExecuteReaderAsync()) + { + if (await reader.ReadAsync()) + { + using (Stream stream = await reader.GetFieldValueAsync(1)) + { + + } + } + } + } +} +``` + +## Target Platform Support + +- .NET Framework 4.6.1+ (Windows x86, Windows x64) +- .NET Core 3.1+ (Windows x86, Windows x64, Windows ARM64, Windows ARM, Linux, macOS) +- .NET Standard 2.0+ (Windows x86, Windows x64, Windows ARM64, Windows ARM, Linux, macOS) + +### Dependencies + +#### .NET Framework + +- Microsoft.Data.SqlClient.SNI 4.0.0-preview1.21232.1 +- Azure.Identity 1.3.0 +- Microsoft.Identity.Client 4.22.0 +- Microsoft.IdentityModel.JsonWebTokens 6.8.0 +- Microsoft.IdentityModel.Protocols.OpenIdConnect 6.8.0 +- System.Buffers 4.5.1 +- System.Configuration.ConfigurationManager 5.0.0 +- System.IO 4.3.0 +- System.Runtime.InteropServices.RuntimeInformation 4.3.0 +- System.Security.Cryptography.Algorithms 4.3.1 +- System.Security.Cryptography.Primitives 4.3.0 +- System.Text.Encodings.Web 4.7.2 + +#### .NET Core + +- Microsoft.Data.SqlClient.SNI.runtime 4.0.0-preview1.21232.1 +- Azure.Identity 1.3.0 +- Microsoft.Identity.Client 4.22.0 +- Microsoft.IdentityModel.Protocols.OpenIdConnect 6.8.0 +- Microsoft.IdentityModel.JsonWebTokens 6.8.0 +- Microsoft.Win32.Registry 5.0.0 +- System.Buffers 4.5.1 +- System.Configuration.ConfigurationManager 5.0.0 +- System.Diagnostics.DiagnosticSource 5.0.0 +- System.IO 4.3.0 +- System.Runtime.Caching 5.0.0 +- System.Text.Encoding.CodePages 5.0.0 +- System.Text.Encodings.Web 4.7.2 +- System.Resources.ResourceManager 4.3.0 +- System.Security.Cryptography.Cng 5.0.0 +- System.Security.Principal.Windows 5.0.0 + +#### .NET Standard + +- Microsoft.Data.SqlClient.SNI.runtime 4.0.0-preview1.21232.1 +- Azure.Identity 1.3.0 +- Microsoft.Identity.Client 4.22.0 +- Microsoft.IdentityModel.Protocols.OpenIdConnect 6.8.0 +- Microsoft.IdentityModel.JsonWebTokens 6.8.0 +- Microsoft.Win32.Registry 5.0.0 +- System.Buffers 4.5.1 +- System.Configuration.ConfigurationManager 5.0.0 +- System.IO 4.3.0 +- System.Runtime.Caching 5.0.0 +- System.Text.Encoding.CodePages 5.0.0 +- System.Text.Encodings.Web 4.7.2 +- System.Resources.ResourceManager 4.3.0 +- System.Runtime.Loader 4.3.0 +- System.Security.Cryptography.Cng 5.0.0 +- System.Security.Principal.Windows 5.0.0 diff --git a/release-notes/4.0/4.0.md b/release-notes/4.0/4.0.md index bde86121f5..f606f704aa 100644 --- a/release-notes/4.0/4.0.md +++ b/release-notes/4.0/4.0.md @@ -4,5 +4,6 @@ The following Microsoft.Data.SqlClient 4.0 preview releases have been shipped: | Release Date | Version | Notes | | :-- | :-- | :--: | +| 2021/10/20 | 4.0.0-preview3.x.x | [release notes](4.0.0-preview3.md) | | 2021/09/21 | 4.0.0-preview2.21264.2 | [release notes](4.0.0-preview2.md) | | 2021/08/25 | 4.0.0-preview1.21237.2 | [release notes](4.0.0-preview1.md) | diff --git a/release-notes/4.0/README.md b/release-notes/4.0/README.md index bde86121f5..f606f704aa 100644 --- a/release-notes/4.0/README.md +++ b/release-notes/4.0/README.md @@ -4,5 +4,6 @@ The following Microsoft.Data.SqlClient 4.0 preview releases have been shipped: | Release Date | Version | Notes | | :-- | :-- | :--: | +| 2021/10/20 | 4.0.0-preview3.x.x | [release notes](4.0.0-preview3.md) | | 2021/09/21 | 4.0.0-preview2.21264.2 | [release notes](4.0.0-preview2.md) | | 2021/08/25 | 4.0.0-preview1.21237.2 | [release notes](4.0.0-preview1.md) | From fb267f90f4a5248527baad5f10f024f6e4880c8b Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Wed, 20 Oct 2021 11:09:59 -0700 Subject: [PATCH 2/9] Update CHANGELOG.md Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1c5983be26..308b0ac8fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,7 +19,7 @@ This update brings the below changes over the previous release: ### Fixed -- Fixed `FormatException` when opening a connection with event tracing enabled [#1290](https://github.com/dotnet/SqlClient/pull/1290) +- Fixed `FormatException` when opening a connection with event tracing enabled [#1291](https://github.com/dotnet/SqlClient/pull/1291) - Fixed improper initialization of `ActiveDirectoryAuthenticationProvider` [#1327](https://github.com/dotnet/SqlClient/pull/1327) - Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1335](https://github.com/dotnet/SqlClient/pull/1335) - Fixed data corruption issues by reverting changes to async cancellations [#1344](https://github.com/dotnet/SqlClient/pull/1344) From a015aec551aea0e9c4e4f988879934480f709430 Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Wed, 20 Oct 2021 11:10:03 -0700 Subject: [PATCH 3/9] Update CHANGELOG.md Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 308b0ac8fc..f492935799 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,7 +22,7 @@ This update brings the below changes over the previous release: - Fixed `FormatException` when opening a connection with event tracing enabled [#1291](https://github.com/dotnet/SqlClient/pull/1291) - Fixed improper initialization of `ActiveDirectoryAuthenticationProvider` [#1327](https://github.com/dotnet/SqlClient/pull/1327) - Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1335](https://github.com/dotnet/SqlClient/pull/1335) -- Fixed data corruption issues by reverting changes to async cancellations [#1344](https://github.com/dotnet/SqlClient/pull/1344) +- Fixed data corruption issues by reverting changes to async cancellations [#1352](https://github.com/dotnet/SqlClient/pull/1352) - Fixed performance degradation by reverting changes to MARS state machine [#1357](https://github.com/dotnet/SqlClient/pull/1357) - Fixed bug where environment variables are ignored when using `ActiveDirectoryDefault` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) From dd8c8062a428546f5876cbfb9cf6c8e8355db558 Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Wed, 20 Oct 2021 11:10:23 -0700 Subject: [PATCH 4/9] address feedback --- CHANGELOG.md | 3 ++- release-notes/4.0/4.0.0-preview3.md | 9 +++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1c5983be26..733b7a13cb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ This update brings the below changes over the previous release: ### Breaking changes over preview release v4.0.0-preview2 - Dropped support for .NET Core 2.1 [#1272](https://github.com/dotnet/SqlClient/pull/1272) -- Exception will not be thrown if a User ID is provided in the connection string when using `ActiveDirectoryIntegrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) +- [.NET Framework] Exception will not be thrown if a User ID is provided in the connection string when using `ActiveDirectoryIntegrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) ### Added @@ -30,6 +30,7 @@ This update brings the below changes over the previous release: - Removed attributes for classes used in Microsoft.VSDesigner due to lack of support for Microsoft.Data.SqlClient [#1296](https://github.com/dotnet/SqlClient/pull/1296) - Disable encryption when connecting to SQL LocalDB [#1312](https://github.com/dotnet/SqlClient/pull/1312) +- Various code health and performance improvements. See [milestone](https://github.com/dotnet/SqlClient/milestone/31?closed=1) for more info. ## [Preview Release 4.0.0-preview2.21264.2] - 2021-09-21 diff --git a/release-notes/4.0/4.0.0-preview3.md b/release-notes/4.0/4.0.0-preview3.md index 53efcc071d..6d7f225807 100644 --- a/release-notes/4.0/4.0.0-preview3.md +++ b/release-notes/4.0/4.0.0-preview3.md @@ -7,11 +7,11 @@ This update brings the below changes over the previous release: ### Breaking changes over preview release v4.0.0-preview2 - Dropped support for .NET Core 2.1 [#1272](https://github.com/dotnet/SqlClient/pull/1272) -- Exception will not be thrown if a User ID is provided in the connection string when using `ActiveDirectoryIntegrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) +- [.NET Framework] Exception will not be thrown if a User ID is provided in the connection string when using `ActiveDirectoryIntegrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) ### Added -- Add `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019) +- Add `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019). [Read more](#`GetFieldValueAsync`-and-`GetFieldValue`-support-for-`XmlReader`,-`TextReader`,-`Stream`-types) ### Fixed @@ -26,13 +26,10 @@ This update brings the below changes over the previous release: - Removed attributes for classes used in Microsoft.VSDesigner due to lack of support for Microsoft.Data.SqlClient [#1296](https://github.com/dotnet/SqlClient/pull/1296) - Disable encryption when connecting to SQL LocalDB [#1312](https://github.com/dotnet/SqlClient/pull/1312) +- Various code health and performance improvements. See [milestone](https://github.com/dotnet/SqlClient/milestone/31?closed=1) for more info. ## New features over preview release v4.0.0-preview2 -### Remove configurable retry logic safety switch - -The App Context switch "Switch.Microsoft.Data.SqlClient.EnableRetryLogic" will no longer be required to use the configurable retry logic feature. The feature is now supported in production. The default behavior of the feature will continue to be a non-retry policy, which will need to be overridden by client applications to enable retries. - ### `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` types `XmlReader`, `TextReader`, `Stream` types are now supported when using `GetFieldValueAsync` and `GetFieldValue`. From 50204adc9c1f3fd16a21df6f2ccf6594512c4142 Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Wed, 20 Oct 2021 11:15:56 -0700 Subject: [PATCH 5/9] typos --- CHANGELOG.md | 2 +- release-notes/4.0/4.0.0-preview3.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d00648ef38..f325ae14df 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ This update brings the below changes over the previous release: ### Added -- Add `GetFieldValue(Async)` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019) +- Add `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019) ### Fixed diff --git a/release-notes/4.0/4.0.0-preview3.md b/release-notes/4.0/4.0.0-preview3.md index 6d7f225807..f709cac95b 100644 --- a/release-notes/4.0/4.0.0-preview3.md +++ b/release-notes/4.0/4.0.0-preview3.md @@ -11,7 +11,7 @@ This update brings the below changes over the previous release: ### Added -- Add `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019). [Read more](#`GetFieldValueAsync`-and-`GetFieldValue`-support-for-`XmlReader`,-`TextReader`,-`Stream`-types) +- Add `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019). [Read more](#`GetFieldValueAsync`-and-`GetFieldValue`-support-for-`XmlReader`,-`TextReader`,-`Stream`-types) ### Fixed From ac93cd151063ffed1f491c0f0fd21d6f34c5df13 Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Wed, 20 Oct 2021 11:50:45 -0700 Subject: [PATCH 6/9] Apply suggestions from code review Co-authored-by: Cheena Malhotra --- CHANGELOG.md | 4 ++-- release-notes/4.0/4.0.0-preview3.md | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f325ae14df..6bc04e62a7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,7 @@ This update brings the below changes over the previous release: ### Breaking changes over preview release v4.0.0-preview2 - Dropped support for .NET Core 2.1 [#1272](https://github.com/dotnet/SqlClient/pull/1272) -- [.NET Framework] Exception will not be thrown if a User ID is provided in the connection string when using `ActiveDirectoryIntegrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) +- [.NET Framework] Exception will not be thrown if a User ID is provided in the connection string when using `Active Directory Integrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) ### Added @@ -24,7 +24,7 @@ This update brings the below changes over the previous release: - Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1335](https://github.com/dotnet/SqlClient/pull/1335) - Fixed data corruption issues by reverting changes to async cancellations [#1352](https://github.com/dotnet/SqlClient/pull/1352) - Fixed performance degradation by reverting changes to MARS state machine [#1357](https://github.com/dotnet/SqlClient/pull/1357) -- Fixed bug where environment variables are ignored when using `ActiveDirectoryDefault` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) +- Fixed bug where environment variables are ignored when using `Active Directory Default` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) ### Changed diff --git a/release-notes/4.0/4.0.0-preview3.md b/release-notes/4.0/4.0.0-preview3.md index f709cac95b..cfc27c51f6 100644 --- a/release-notes/4.0/4.0.0-preview3.md +++ b/release-notes/4.0/4.0.0-preview3.md @@ -7,7 +7,7 @@ This update brings the below changes over the previous release: ### Breaking changes over preview release v4.0.0-preview2 - Dropped support for .NET Core 2.1 [#1272](https://github.com/dotnet/SqlClient/pull/1272) -- [.NET Framework] Exception will not be thrown if a User ID is provided in the connection string when using `ActiveDirectoryIntegrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) +- [.NET Framework] Exception will not be thrown if a User ID is provided in the connection string when using `Active Directory Integrated` authentication [#1359](https://github.com/dotnet/SqlClient/pull/1359) ### Added @@ -20,7 +20,7 @@ This update brings the below changes over the previous release: - Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1335](https://github.com/dotnet/SqlClient/pull/1335) - Fixed data corruption issues by reverting changes to async cancellations [#1344](https://github.com/dotnet/SqlClient/pull/1344) - Fixed performance degradation by reverting changes to MARS state machine [#1357](https://github.com/dotnet/SqlClient/pull/1357) -- Fixed bug where environment variables are ignored when using `ActiveDirectoryDefault` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) +- Fixed bug where environment variables are ignored when using `Active Directory Default` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) ### Changed @@ -48,7 +48,7 @@ using (SqlConnection connection = new SqlConnection(connectionString)) { using (Stream stream = await reader.GetFieldValueAsync(1)) { - + // Continue to read from stream } } } From 055c7bf0be1ba1bfaa3fb0dbf45f043660f8fb35 Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Wed, 20 Oct 2021 12:32:13 -0700 Subject: [PATCH 7/9] Update release-notes/4.0/4.0.0-preview3.md Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> --- release-notes/4.0/4.0.0-preview3.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release-notes/4.0/4.0.0-preview3.md b/release-notes/4.0/4.0.0-preview3.md index cfc27c51f6..f232652438 100644 --- a/release-notes/4.0/4.0.0-preview3.md +++ b/release-notes/4.0/4.0.0-preview3.md @@ -11,7 +11,7 @@ This update brings the below changes over the previous release: ### Added -- Add `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019). [Read more](#`GetFieldValueAsync`-and-`GetFieldValue`-support-for-`XmlReader`,-`TextReader`,-`Stream`-types) +- Add `GetFieldValueAsync` and `GetFieldValue` support for `XmlReader`, `TextReader`, `Stream` [#1019](https://github.com/dotnet/SqlClient/pull/1019). [Read more](#getfieldvalueasynct-and-getfieldvaluet-support-for-xmlreader-textreader-stream-types) ### Fixed From 2291d45b592dfaa4c9983e3696dd481d493b49f6 Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Wed, 20 Oct 2021 12:55:58 -0700 Subject: [PATCH 8/9] Apply suggestions from code review Co-authored-by: DavoudEshtehari <61173489+DavoudEshtehari@users.noreply.github.com> --- CHANGELOG.md | 4 ++-- release-notes/4.0/4.0.0-preview3.md | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6bc04e62a7..08262cb9ae 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,8 +20,8 @@ This update brings the below changes over the previous release: ### Fixed - Fixed `FormatException` when opening a connection with event tracing enabled [#1291](https://github.com/dotnet/SqlClient/pull/1291) -- Fixed improper initialization of `ActiveDirectoryAuthenticationProvider` [#1327](https://github.com/dotnet/SqlClient/pull/1327) -- Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1335](https://github.com/dotnet/SqlClient/pull/1335) +- Fixed improper initialization of `ActiveDirectoryAuthenticationProvider` [#1328](https://github.com/dotnet/SqlClient/pull/1328) +- Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1336](https://github.com/dotnet/SqlClient/pull/1336) - Fixed data corruption issues by reverting changes to async cancellations [#1352](https://github.com/dotnet/SqlClient/pull/1352) - Fixed performance degradation by reverting changes to MARS state machine [#1357](https://github.com/dotnet/SqlClient/pull/1357) - Fixed bug where environment variables are ignored when using `Active Directory Default` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) diff --git a/release-notes/4.0/4.0.0-preview3.md b/release-notes/4.0/4.0.0-preview3.md index f232652438..5020975b72 100644 --- a/release-notes/4.0/4.0.0-preview3.md +++ b/release-notes/4.0/4.0.0-preview3.md @@ -15,10 +15,10 @@ This update brings the below changes over the previous release: ### Fixed -- Fixed `FormatException` when opening a connection with event tracing enabled [#1290](https://github.com/dotnet/SqlClient/pull/1290) -- Fixed improper initialization of `ActiveDirectoryAuthenticationProvider` [#1327](https://github.com/dotnet/SqlClient/pull/1327) -- Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1335](https://github.com/dotnet/SqlClient/pull/1335) -- Fixed data corruption issues by reverting changes to async cancellations [#1344](https://github.com/dotnet/SqlClient/pull/1344) +- Fixed `FormatException` when opening a connection with event tracing enabled [#1291](https://github.com/dotnet/SqlClient/pull/1291) +- Fixed improper initialization of `ActiveDirectoryAuthenticationProvider` [#1328](https://github.com/dotnet/SqlClient/pull/1328) +- Fixed `MissingMethodException` when accessing `SqlAuthenticationParameters.ConnectionTimeout` [#1336](https://github.com/dotnet/SqlClient/pull/1336) +- Fixed data corruption issues by reverting changes to async cancellations [#1352](https://github.com/dotnet/SqlClient/pull/1352) - Fixed performance degradation by reverting changes to MARS state machine [#1357](https://github.com/dotnet/SqlClient/pull/1357) - Fixed bug where environment variables are ignored when using `Active Directory Default` authentication [#1360](https://github.com/dotnet/SqlClient/pull/1360) From a4197f6db81ae37e70d6b006516e195298647a92 Mon Sep 17 00:00:00 2001 From: Johnny Pham Date: Wed, 20 Oct 2021 15:14:28 -0700 Subject: [PATCH 9/9] update version number --- CHANGELOG.md | 2 +- release-notes/4.0/4.0.0-preview3.md | 2 +- release-notes/4.0/4.0.md | 2 +- release-notes/4.0/README.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 08262cb9ae..900703d501 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) -## [Preview Release 4.0.0-preview3.x.x] - 2021-10-20 +## [Preview Release 4.0.0-preview3.21293.2] - 2021-10-20 This update brings the below changes over the previous release: diff --git a/release-notes/4.0/4.0.0-preview3.md b/release-notes/4.0/4.0.0-preview3.md index 5020975b72..005ae6db0c 100644 --- a/release-notes/4.0/4.0.0-preview3.md +++ b/release-notes/4.0/4.0.0-preview3.md @@ -1,6 +1,6 @@ # Release Notes -## Microsoft.Data.SqlClient 4.0.0-preview3.x.x released 20 October 2021 +## Microsoft.Data.SqlClient 4.0.0-preview3.21293.2 released 20 October 2021 This update brings the below changes over the previous release: diff --git a/release-notes/4.0/4.0.md b/release-notes/4.0/4.0.md index f606f704aa..d9f8ceac96 100644 --- a/release-notes/4.0/4.0.md +++ b/release-notes/4.0/4.0.md @@ -4,6 +4,6 @@ The following Microsoft.Data.SqlClient 4.0 preview releases have been shipped: | Release Date | Version | Notes | | :-- | :-- | :--: | -| 2021/10/20 | 4.0.0-preview3.x.x | [release notes](4.0.0-preview3.md) | +| 2021/10/20 | 4.0.0-preview3.21293.2 | [release notes](4.0.0-preview3.md) | | 2021/09/21 | 4.0.0-preview2.21264.2 | [release notes](4.0.0-preview2.md) | | 2021/08/25 | 4.0.0-preview1.21237.2 | [release notes](4.0.0-preview1.md) | diff --git a/release-notes/4.0/README.md b/release-notes/4.0/README.md index f606f704aa..d9f8ceac96 100644 --- a/release-notes/4.0/README.md +++ b/release-notes/4.0/README.md @@ -4,6 +4,6 @@ The following Microsoft.Data.SqlClient 4.0 preview releases have been shipped: | Release Date | Version | Notes | | :-- | :-- | :--: | -| 2021/10/20 | 4.0.0-preview3.x.x | [release notes](4.0.0-preview3.md) | +| 2021/10/20 | 4.0.0-preview3.21293.2 | [release notes](4.0.0-preview3.md) | | 2021/09/21 | 4.0.0-preview2.21264.2 | [release notes](4.0.0-preview2.md) | | 2021/08/25 | 4.0.0-preview1.21237.2 | [release notes](4.0.0-preview1.md) |