From 0757e0e96be25b649dc5faa905ecd8222f49c174 Mon Sep 17 00:00:00 2001 From: Kaur-Parminder Date: Wed, 12 Jan 2022 16:20:14 -0800 Subject: [PATCH 1/2] Increasing thread sleep period to address the intermittent failure --- .../SQL/ConnectionPoolTest/ConnectionPoolTest.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs index 41a6404a20..4a93c3e874 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs @@ -185,7 +185,11 @@ public static void MaxPoolWaitForConnectionTest(string connectionString) ManualResetEventSlim taskAllowedToSpeak = new ManualResetEventSlim(false); Task waitTask = Task.Factory.StartNew(() => MaxPoolWaitForConnectionTask(newConnectionString, internalConnection, connectionPool, taskAllowedToSpeak)); - Thread.Sleep(200); + int cnt = 5; + while (waitTask.Status == TaskStatus.WaitingToRun && cnt-- > 0) + { + Thread.Sleep(200); + } Assert.Equal(TaskStatus.Running, waitTask.Status); connection1.Close(); From 44dc4c84440d799df4bbd3d1012f32254b258301 Mon Sep 17 00:00:00 2001 From: Kaur-Parminder Date: Thu, 13 Jan 2022 14:25:19 -0800 Subject: [PATCH 2/2] review comment --- .../ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs index 4a93c3e874..cfe74831f7 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs @@ -185,8 +185,8 @@ public static void MaxPoolWaitForConnectionTest(string connectionString) ManualResetEventSlim taskAllowedToSpeak = new ManualResetEventSlim(false); Task waitTask = Task.Factory.StartNew(() => MaxPoolWaitForConnectionTask(newConnectionString, internalConnection, connectionPool, taskAllowedToSpeak)); - int cnt = 5; - while (waitTask.Status == TaskStatus.WaitingToRun && cnt-- > 0) + int count = 5; + while (waitTask.Status == TaskStatus.WaitingToRun && count-- > 0) { Thread.Sleep(200); }