Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incorrect event id and opcode for the SqlEventSource. #241

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@stebet
Copy link
Contributor

stebet commented Oct 3, 2019

Incorrect event ids are defined on the BeginExecuteEventId, resulting in in errors when WriteEvent is called for the Event Source. That again results in for example Application Insights being unable to properly track SQL dependency calls made with Microsoft.Data.SqlClient.

See this issue for reference: https://github.com/microsoft/ApplicationInsights-dotnet-server/issues/1282

@cheenamalhotra cheenamalhotra added this to the 1.1.0-preview2 milestone Oct 3, 2019
@cheenamalhotra cheenamalhotra merged commit de6e901 into dotnet:master Oct 4, 2019
6 checks passed
6 checks passed
Azure-Ubuntu-1804-Microsoft.Data.SqlClient #20191003.2 succeeded
Details
Azure-Win10-Microsoft.Data.SqlClient #20191003.4 succeeded
Details
Ubuntu-1604-Microsoft.Data.SqlClient #20191003.2 succeeded
Details
WIP Ready for review
Details
Win-10-Microsoft.Data.SqlClient #20191003.7 succeeded
Details
license/cla All CLA requirements met.
yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.