Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incorrect event id and opcode for the SqlEventSource. #241

Merged
merged 1 commit into from Oct 4, 2019

Conversation

stebet
Copy link
Contributor

@stebet stebet commented Oct 3, 2019

Incorrect event ids are defined on the BeginExecuteEventId, resulting in in errors when WriteEvent is called for the Event Source. That again results in for example Application Insights being unable to properly track SQL dependency calls made with Microsoft.Data.SqlClient.

See this issue for reference: https://github.com/microsoft/ApplicationInsights-dotnet-server/issues/1282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants