-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of TorchSharp and LibTorchSharp: exposing LibTorch C++ training API #80
Conversation
Added types for Torch tensors.
* Added a way to create pinned array from already allocated arrays
* Fixed MNIST example
Add eq and add with scalars
…n the repo in other places
Integration
I believe Miguel already set up this, we probably only need to point to the right build. |
@@ -1,18 +1,17 @@ | |||
[![Build Status](https://migueldeicaza.visualstudio.com/TorchSharp/_apis/build/status/TorchSharp-CI)](https://migueldeicaza.visualstudio.com/TorchSharp/_build/latest?definitionId=5) | |||
|
|||
TorchSharp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the README with the new info on how to build / platform supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we have Azure Pipelines set up, right? (At least for build and test). Can you please add those too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Miguel needs to add a new pipeline from DevOps since I have changed the file names of the yml files specifying the build instructions.
To me the PR is ok. We will fill a couple of issues to address the known limitations once merged. @migueldeicaza if is ok with I will go ahead and merge it. We will need your help to set up the pipelines (we don't have access to the DevOps account for this repo) and to refresh the docs. |
…t work. Added an example of if statement in a model to test that eager evaluation is actually correct.
Agreed - let us merge it now and work on the outstanding issues. Would love to know what happened with the docs that needs work |
This PR fixes #79.
A summary of what this PR does:
Shortcomings (things that will need fixing):
Notice:
We probably need to instruct DevOps to look for new build definitions in the following two yml files (one for the official build and the other for the PR verification build).
Let me know if I should target another branch (other than master) to begin, and of course I am happy to make any changes that you think are needed to check this in.
/cc: @interesaaat @MiguelCaldasMS