Un-strip Material Icons Core binding so the Icons type binds#1454
Merged
jonathanpeppers merged 3 commits intoJun 7, 2026
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix empty managed assembly issue in Xamarin.AndroidX.Compose.Material.Icons.Core
Un-strip Material Icons Core binding so the Icons type binds
Jun 7, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes the Xamarin.AndroidX.Compose.Material.Icons.Core.Android binding producing an empty managed assembly by un-stripping the material-icons-core-android API surface, allowing the AndroidX.Compose.Material.Icons.Icons type (and related icon set namespaces) to bind and be published.
Changes:
- Removed the blanket
/api/packageremoval transform frommaterial-icons-core-androidso upstream types are no longer stripped. - Updated the regenerated public API surface for
material-icons-core-android. - Added newly published
AndroidX.Compose.Material.Icons.*namespaces and bumped NuGet revision for the affected artifacts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/androidx.compose.material/material-icons-core-android/Transforms/Metadata.xml | Stops stripping all packages so Icons and related types bind. |
| source/androidx.compose.material/material-icons-core-android/PublicAPI/PublicAPI.Unshipped.txt | Regenerated PublicAPI entries reflecting the newly exposed surface. |
| published-namespaces.txt | Adds the new AndroidX.Compose.Material.Icons.* namespaces to the published list. |
| config.json | Bumps NuGet revision for material-icons-core and material-icons-core-android to ship the binding-only change. |
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
jonathanpeppers
approved these changes
Jun 7, 2026
jonathanpeppers
deleted the
copilot/xamarin-androidx-compose-empty-assembly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xamarin.AndroidX.Compose.Material.Icons.Core.Androidshipped an empty managed assembly: the-androidbinding'sMetadata.xmlremoved/api/packagewholesale, stripping all 282 upstream classes includingandroidx.compose.material.icons.Icons.Changes
material-icons-core-android/Transforms/Metadata.xml— drop the blanket<remove-node path="/api/package" />. The binding compiles clean, exposingIconsplus theFilled/Outlined/Rounded/Sharp/TwoTone/AutoMirroredicon sets. AddedmanagedNametransforms for the fiveautomirrored.*packages so they bind underAndroidX.Compose.Material.Icons.AutoMirrored.*(proper C# casing).PublicAPI.Unshipped.txt— regenerated (Iconstype + nested sets,AutoMirroredcasing).published-namespaces.txt— add the 11 newAndroidX.Compose.Material.Icons.*namespaces (AutoMirroredcasing).config.json— bumpmaterial-icons-coreandmaterial-icons-core-android1.7.8.5→1.7.8.6.The non-
.Androidmaterial-icons-coreAAR carries noclasses.jar(manifest only), so it stays empty by design — the types live in the-androidartifact per the KMP metapackage layout.