[XA.Build.Tasks] Update possible values for manifest foregroundServiceType. #4753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
foreground-manifest
branch
from
c56bbab
to
df1892f
Compare
jpobst
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
jonpryor
pushed a commit
that referenced
this pull request
Jun 3, 2020
…4753) Fixes: #4752 Context: https://developer.android.com/preview/privacy/foreground-service-types In 6e55c22 we added a `ServiceAttribute.ForegroundServiceType` property to support emitting the `//service/@android:foregroundServiceType` XML attribute within `AndroidManifest.xml`. `//service/@android:foregroundServiceType` supports multiple `|`-separated values, e.g.: <service … android:foregroundServiceType="location|camera|microphone" /> Unfortunately, the code in 6e55c22 only supported a single value, so if you attempted to do e.g.: [Service (…, ForegroundServiceType = ForegroundService.TypeDataSync | ForegroundService.TypeLocation)] partial class MyService : Service { } you would get an error such as: …\Xamarin.Android.Common.targets(2004,3): error XAGJS7004: System.ArgumentException: Unsupported ForegroundServiceType value '9'. …\Xamarin.Android.Common.targets(2004,3): error XAGJS7004: Parameter name: value …\Xamarin.Android.Common.targets(2004,3): error XAGJS7004: at Xamarin.Android.Manifest.ManifestDocumentElement`1.ToString(ForegroundService value) … Make the `ForegroundService` enum a `[Flags]` enum, and update `ManifestDocumentElement<T>.ToString(ForegroundService)` so that `ForegroundService` is handled appropriately, allowing it to emit `|`-separated values. Additionally, add "preview" support for the `camera` and `microphone` values which are added in API-R. Note that we cannot use the enum values yet for API-R because `Xamarin.Android.Build.Tasks.dll` is built against the stable version of `Mono.Android.dll` (API-29), which does not have these values. I also audited the rest of the enumerations used in `ManifestDocumenetElements` to ensure no other values were added in API-R.
jonpryor
pushed a commit
that referenced
this pull request
Jun 3, 2020
…4753) Fixes: #4752 Context: https://developer.android.com/preview/privacy/foreground-service-types In 6e55c22 we added a `ServiceAttribute.ForegroundServiceType` property to support emitting the `//service/@android:foregroundServiceType` XML attribute within `AndroidManifest.xml`. `//service/@android:foregroundServiceType` supports multiple `|`-separated values, e.g.: <service … android:foregroundServiceType="location|camera|microphone" /> Unfortunately, the code in 6e55c22 only supported a single value, so if you attempted to do e.g.: [Service (…, ForegroundServiceType = ForegroundService.TypeDataSync | ForegroundService.TypeLocation)] partial class MyService : Service { } you would get an error such as: …\Xamarin.Android.Common.targets(2004,3): error XAGJS7004: System.ArgumentException: Unsupported ForegroundServiceType value '9'. …\Xamarin.Android.Common.targets(2004,3): error XAGJS7004: Parameter name: value …\Xamarin.Android.Common.targets(2004,3): error XAGJS7004: at Xamarin.Android.Manifest.ManifestDocumentElement`1.ToString(ForegroundService value) … Make the `ForegroundService` enum a `[Flags]` enum, and update `ManifestDocumentElement<T>.ToString(ForegroundService)` so that `ForegroundService` is handled appropriately, allowing it to emit `|`-separated values. Additionally, add "preview" support for the `camera` and `microphone` values which are added in API-R. Note that we cannot use the enum values yet for API-R because `Xamarin.Android.Build.Tasks.dll` is built against the stable version of `Mono.Android.dll` (API-29), which does not have these values. I also audited the rest of the enumerations used in `ManifestDocumenetElements` to ensure no other values were added in API-R.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4752
Context: https://developer.android.com/preview/privacy/foreground-service-types
In #3810 we added
foregroundServiceTypeas an attribute for<service>. This attribute supports multiple values like:However, our code only supports a single value, so you will end up with an error like
Unsupported ForegroundServiceType value '9'if you attempt to pass itForegroundService.TypeDataSync | ForegroundService.TypeLocation.This PR:
[Flags]attribute toAndroid.Content.PM.ForegroundServicecameraandmicrophonevalues added in API-RNote we cannot use the enum values yet for API-R because
Xamarin.Android.Build.Tasksis built against the stable version ofMono.Android.dll(29) which does not have these values.I also audited the rest of the enumerations used in
ManifestDocumenetElementsto ensure no other values were added in API-R.