Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of read-collaborator access #144

Open
terrajobst opened this issue Dec 10, 2019 · 0 comments
Open

Removal of read-collaborator access #144

terrajobst opened this issue Dec 10, 2019 · 0 comments
Labels

Comments

@terrajobst
Copy link
Member

@terrajobst terrajobst commented Dec 10, 2019

TL;DR: We’ll remove collaborators with read-only access from our public repos on December 16th. This means some folks will lose their Collaborator badge and the ability to interact with the CI system.

Over the years, we’ve added a bunch of folks as collaborators with read permissions to our public repos. The rationale was that we wanted to be able to assign issues to community members because GitHub only allowed assigning issues to users with an explicit permission grant for the repository. However, they changed this in June 2019. Now, we can assign issues to all users with explicit permissions as well as to users that have commented on the specific issue.

Also, we recently started to audit and tighten the permissions for our organizations. As a result, it became clear that large number of repo-specific permission grants are hard to review and audit. Internally, our goal is to grant all permissions via teams instead.

Hence, we plan to remove all collaborators from public repos that only have read permissions (folks with triage permissions will remain). The full list of affected repos is listed below.

This shouldn’t impact your ability to work with us, but losing explicit read-only has the following implications:

  • You’ll lose the collaborator badge. We understand that this is visually appealing and for some people it might have been a badge of honor. But given that GitHub also shows a Contributor bade for folks whose PRs got merged, we don’t think it this will be a major take back.
    image

  • You lose the ability to interact with the CI system. As a collaborator, you can use comments to send commands to the CI system. While this can be useful at times, we generally don’t expect (or desire) contributors to do that. Of course, anyone can still access the CI logs.

  • You might lose the ability to interact with the CI system. Based on your feedback we have decided to give externals access to interact with the CI system on a case by case basis. If you believe you need to have that ability, please leave a comment like Kevin's.

Public Repo #collaborators with read
arcade 1
BenchmarkDotNet 11
cli 2
command-line-api 14
coreclr 18
corefx 180
corefxlab 4
corert 7
core-sdk 1
docs 3
interactive-window 1
machinelearning 1
machinelearning-samples 1
msbuild-language-service 1
runtime 128
spark 5
standard 1
windowsdesktop 1
winforms-datavisualization 1
Grand Total 381

Discussion

To discuss this, please comment on the corresponding issue at dotnet/runtime#718.

@dotnet dotnet locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.