From d1ee4589823267fc5b1e65945b02abecdd19a24e Mon Sep 17 00:00:00 2001
From: Nate McMaster <natemcmaster@users.noreply.github.com>
Date: Thu, 15 Nov 2018 16:18:58 -0800
Subject: [PATCH] Remove assemblies from the shared framework (#4004)

Remove assemblies from the shared framework that depend on or contain the following:

* Entity Framework Core
* Owin
* Node and SPA services
* Identity UI
* Middleware analysis
* SQL Client
* Third-party oauth integrations
* Runtime razor components
* JsonPatch
---
 .../Microsoft.AspNetCore.App.props            | 28 +----------------
 .../Templates/WebTemplate.cs                  | 30 -------------------
 2 files changed, 1 insertion(+), 57 deletions(-)

diff --git a/src/Framework/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.props b/src/Framework/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.props
index cc6d609edfab..8acb3e61f124 100644
--- a/src/Framework/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.props
+++ b/src/Framework/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.props
@@ -9,14 +9,9 @@
     <Dependency Include="Microsoft.AspNetCore.Authentication.Abstractions"             Version="$(MicrosoftAspNetCoreAuthenticationAbstractionsPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Authentication.Cookies"                  Version="$(MicrosoftAspNetCoreAuthenticationCookiesPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Authentication.Core"                     Version="$(MicrosoftAspNetCoreAuthenticationCorePackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Authentication.Facebook"                 Version="$(MicrosoftAspNetCoreAuthenticationFacebookPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Authentication.Google"                   Version="$(MicrosoftAspNetCoreAuthenticationGooglePackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Authentication.JwtBearer"                Version="$(MicrosoftAspNetCoreAuthenticationJwtBearerPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Authentication.MicrosoftAccount"         Version="$(MicrosoftAspNetCoreAuthenticationMicrosoftAccountPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Authentication.OAuth"                    Version="$(MicrosoftAspNetCoreAuthenticationOAuthPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Authentication.OpenIdConnect"            Version="$(MicrosoftAspNetCoreAuthenticationOpenIdConnectPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Authentication.Twitter"                  Version="$(MicrosoftAspNetCoreAuthenticationTwitterPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Authentication.WsFederation"             Version="$(MicrosoftAspNetCoreAuthenticationWsFederationPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Authentication"                          Version="$(MicrosoftAspNetCoreAuthenticationPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Authorization.Policy"                    Version="$(MicrosoftAspNetCoreAuthorizationPolicyPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Authorization"                           Version="$(MicrosoftAspNetCoreAuthorizationPackageVersion)" />
@@ -29,7 +24,6 @@
     <Dependency Include="Microsoft.AspNetCore.DataProtection.Extensions"               Version="$(MicrosoftAspNetCoreDataProtectionExtensionsPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.DataProtection"                          Version="$(MicrosoftAspNetCoreDataProtectionPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Diagnostics.Abstractions"                Version="$(MicrosoftAspNetCoreDiagnosticsAbstractionsPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore"         Version="$(MicrosoftAspNetCoreDiagnosticsEntityFrameworkCorePackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Diagnostics.HealthChecks"                Version="$(MicrosoftAspNetCoreDiagnosticsHealthChecksPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Diagnostics"                             Version="$(MicrosoftAspNetCoreDiagnosticsPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.HostFiltering"                           Version="$(MicrosoftAspNetCoreHostFilteringPackageVersion)" />
@@ -45,13 +39,9 @@
     <Dependency Include="Microsoft.AspNetCore.Http"                                    Version="$(MicrosoftAspNetCoreHttpPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.HttpOverrides"                           Version="$(MicrosoftAspNetCoreHttpOverridesPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.HttpsPolicy"                             Version="$(MicrosoftAspNetCoreHttpsPolicyPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore"            Version="$(MicrosoftAspNetCoreIdentityEntityFrameworkCorePackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Identity.UI"                             Version="$(MicrosoftAspNetCoreIdentityUIPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Identity"                                Version="$(MicrosoftAspNetCoreIdentityPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.JsonPatch"                               Version="$(MicrosoftAspNetCoreJsonPatchPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Localization.Routing"                    Version="$(MicrosoftAspNetCoreLocalizationRoutingPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Localization"                            Version="$(MicrosoftAspNetCoreLocalizationPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.MiddlewareAnalysis"                      Version="$(MicrosoftAspNetCoreMiddlewareAnalysisPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.Abstractions"                        Version="$(MicrosoftAspNetCoreMvcAbstractionsPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.Analyzers"                           Version="$(MicrosoftAspNetCoreMvcAnalyzersPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.ApiExplorer"                         Version="$(MicrosoftAspNetCoreMvcApiExplorerPackageVersion)" />
@@ -61,17 +51,13 @@
     <Dependency Include="Microsoft.AspNetCore.Mvc.Formatters.Json"                     Version="$(MicrosoftAspNetCoreMvcFormattersJsonPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.Formatters.Xml"                      Version="$(MicrosoftAspNetCoreMvcFormattersXmlPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.Localization"                        Version="$(MicrosoftAspNetCoreMvcLocalizationPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Mvc.Razor.Extensions"                    Version="$(MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.Razor"                               Version="$(MicrosoftAspNetCoreMvcRazorPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.RazorPages"                          Version="$(MicrosoftAspNetCoreMvcRazorPagesPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.TagHelpers"                          Version="$(MicrosoftAspNetCoreMvcTagHelpersPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc.ViewFeatures"                        Version="$(MicrosoftAspNetCoreMvcViewFeaturesPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Mvc"                                     Version="$(MicrosoftAspNetCoreMvcPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.NodeServices"                            Version="$(MicrosoftAspNetCoreNodeServicesPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Owin"                                    Version="$(MicrosoftAspNetCoreOwinPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Razor.Language"                          Version="$(MicrosoftAspNetCoreRazorLanguagePackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.Razor.Runtime"                           Version="$(MicrosoftAspNetCoreRazorRuntimePackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.Razor"                                   Version="$(MicrosoftAspNetCoreRazorPackageVersion)" />
+    <Dependency Include="Microsoft.AspNetCore.Razor.Runtime"                           Version="$(MicrosoftAspNetCoreRazorRuntimePackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.ResponseCaching.Abstractions"            Version="$(MicrosoftAspNetCoreResponseCachingAbstractionsPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.ResponseCaching"                         Version="$(MicrosoftAspNetCoreResponseCachingPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.ResponseCompression"                     Version="$(MicrosoftAspNetCoreResponseCompressionPackageVersion)" />
@@ -91,24 +77,12 @@
     <Dependency Include="Microsoft.AspNetCore.SignalR.Core"                            Version="$(MicrosoftAspNetCoreSignalRCorePackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.SignalR.Protocols.Json"                  Version="$(MicrosoftAspNetCoreSignalRProtocolsJsonPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.SignalR"                                 Version="$(MicrosoftAspNetCoreSignalRPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.SpaServices.Extensions"                  Version="$(MicrosoftAspNetCoreSpaServicesExtensionsPackageVersion)" />
-    <Dependency Include="Microsoft.AspNetCore.SpaServices"                             Version="$(MicrosoftAspNetCoreSpaServicesPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.StaticFiles"                             Version="$(MicrosoftAspNetCoreStaticFilesPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.WebSockets"                              Version="$(MicrosoftAspNetCoreWebSocketsPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore.WebUtilities"                            Version="$(MicrosoftAspNetCoreWebUtilitiesPackageVersion)" />
     <Dependency Include="Microsoft.AspNetCore"                                         Version="$(MicrosoftAspNetCorePackageVersion)" />
-    <Dependency Include="Microsoft.CodeAnalysis.Razor"                                 Version="$(MicrosoftCodeAnalysisRazorPackageVersion)" />
-    <Dependency Include="Microsoft.EntityFrameworkCore.Abstractions"                   Version="$(MicrosoftEntityFrameworkCoreAbstractionsPackageVersion)" />
-    <Dependency Include="Microsoft.EntityFrameworkCore.Analyzers"                      Version="$(MicrosoftEntityFrameworkCoreAnalyzersPackageVersion)" />
-    <Dependency Include="Microsoft.EntityFrameworkCore.Design"                         Version="$(MicrosoftEntityFrameworkCoreDesignPackageVersion)" />
-    <Dependency Include="Microsoft.EntityFrameworkCore.InMemory"                       Version="$(MicrosoftEntityFrameworkCoreInMemoryPackageVersion)" />
-    <Dependency Include="Microsoft.EntityFrameworkCore.Relational"                     Version="$(MicrosoftEntityFrameworkCoreRelationalPackageVersion)" />
-    <Dependency Include="Microsoft.EntityFrameworkCore.SqlServer"                      Version="$(MicrosoftEntityFrameworkCoreSqlServerPackageVersion)" />
-    <Dependency Include="Microsoft.EntityFrameworkCore.Tools"                          Version="$(MicrosoftEntityFrameworkCoreToolsPackageVersion)" />
-    <Dependency Include="Microsoft.EntityFrameworkCore"                                Version="$(MicrosoftEntityFrameworkCorePackageVersion)" />
     <Dependency Include="Microsoft.Extensions.Caching.Abstractions"                    Version="$(MicrosoftExtensionsCachingAbstractionsPackageVersion)" />
     <Dependency Include="Microsoft.Extensions.Caching.Memory"                          Version="$(MicrosoftExtensionsCachingMemoryPackageVersion)" />
-    <Dependency Include="Microsoft.Extensions.Caching.SqlServer"                       Version="$(MicrosoftExtensionsCachingSqlServerPackageVersion)" />
     <Dependency Include="Microsoft.Extensions.Configuration.Abstractions"              Version="$(MicrosoftExtensionsConfigurationAbstractionsPackageVersion)" />
     <Dependency Include="Microsoft.Extensions.Configuration.Binder"                    Version="$(MicrosoftExtensionsConfigurationBinderPackageVersion)" />
     <Dependency Include="Microsoft.Extensions.Configuration.CommandLine"               Version="$(MicrosoftExtensionsConfigurationCommandLinePackageVersion)" />
diff --git a/test/Cli.FunctionalTests/Templates/WebTemplate.cs b/test/Cli.FunctionalTests/Templates/WebTemplate.cs
index 783b02eddb6f..b105638de6fd 100644
--- a/test/Cli.FunctionalTests/Templates/WebTemplate.cs
+++ b/test/Cli.FunctionalTests/Templates/WebTemplate.cs
@@ -47,14 +47,9 @@ public class WebTemplate : ConsoleApplicationTemplate
                         "Microsoft.AspNetCore.Authentication.Cookies.dll",
                         "Microsoft.AspNetCore.Authentication.Core.dll",
                         "Microsoft.AspNetCore.Authentication.dll",
-                        "Microsoft.AspNetCore.Authentication.Facebook.dll",
-                        "Microsoft.AspNetCore.Authentication.Google.dll",
                         "Microsoft.AspNetCore.Authentication.JwtBearer.dll",
-                        "Microsoft.AspNetCore.Authentication.MicrosoftAccount.dll",
                         "Microsoft.AspNetCore.Authentication.OAuth.dll",
                         "Microsoft.AspNetCore.Authentication.OpenIdConnect.dll",
-                        "Microsoft.AspNetCore.Authentication.Twitter.dll",
-                        "Microsoft.AspNetCore.Authentication.WsFederation.dll",
                         "Microsoft.AspNetCore.Authorization.dll",
                         "Microsoft.AspNetCore.Authorization.Policy.dll",
                         "Microsoft.AspNetCore.Connections.Abstractions.dll",
@@ -67,7 +62,6 @@ public class WebTemplate : ConsoleApplicationTemplate
                         "Microsoft.AspNetCore.DataProtection.Extensions.dll",
                         "Microsoft.AspNetCore.Diagnostics.Abstractions.dll",
                         "Microsoft.AspNetCore.Diagnostics.dll",
-                        "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.dll",
                         "Microsoft.AspNetCore.Diagnostics.HealthChecks.dll",
                         "Microsoft.AspNetCore.dll",
                         "Microsoft.AspNetCore.HostFiltering.dll",
@@ -84,14 +78,8 @@ public class WebTemplate : ConsoleApplicationTemplate
                         "Microsoft.AspNetCore.HttpOverrides.dll",
                         "Microsoft.AspNetCore.HttpsPolicy.dll",
                         "Microsoft.AspNetCore.Identity.dll",
-                        "Microsoft.AspNetCore.Identity.EntityFrameworkCore.dll",
-                        "Microsoft.AspNetCore.Identity.UI.dll",
-                        "Microsoft.AspNetCore.Identity.UI.Views.V3.dll",
-                        "Microsoft.AspNetCore.Identity.UI.Views.V4.dll",
-                        "Microsoft.AspNetCore.JsonPatch.dll",
                         "Microsoft.AspNetCore.Localization.dll",
                         "Microsoft.AspNetCore.Localization.Routing.dll",
-                        "Microsoft.AspNetCore.MiddlewareAnalysis.dll",
                         "Microsoft.AspNetCore.Mvc.Abstractions.dll",
                         "Microsoft.AspNetCore.Mvc.ApiExplorer.dll",
                         "Microsoft.AspNetCore.Mvc.Core.dll",
@@ -102,14 +90,11 @@ public class WebTemplate : ConsoleApplicationTemplate
                         "Microsoft.AspNetCore.Mvc.Formatters.Xml.dll",
                         "Microsoft.AspNetCore.Mvc.Localization.dll",
                         "Microsoft.AspNetCore.Mvc.Razor.dll",
-                        "Microsoft.AspNetCore.Mvc.Razor.Extensions.dll",
                         "Microsoft.AspNetCore.Mvc.RazorPages.dll",
                         "Microsoft.AspNetCore.Mvc.TagHelpers.dll",
                         "Microsoft.AspNetCore.Mvc.ViewFeatures.dll",
                         "Microsoft.AspNetCore.NodeServices.dll",
-                        "Microsoft.AspNetCore.Owin.dll",
                         "Microsoft.AspNetCore.Razor.dll",
-                        "Microsoft.AspNetCore.Razor.Language.dll",
                         "Microsoft.AspNetCore.Razor.Runtime.dll",
                         "Microsoft.AspNetCore.ResponseCaching.Abstractions.dll",
                         "Microsoft.AspNetCore.ResponseCaching.dll",
@@ -130,8 +115,6 @@ public class WebTemplate : ConsoleApplicationTemplate
                         "Microsoft.AspNetCore.SignalR.Core.dll",
                         "Microsoft.AspNetCore.SignalR.dll",
                         "Microsoft.AspNetCore.SignalR.Protocols.Json.dll",
-                        "Microsoft.AspNetCore.SpaServices.dll",
-                        "Microsoft.AspNetCore.SpaServices.Extensions.dll",
                         "Microsoft.AspNetCore.StaticFiles.dll",
                         "Microsoft.AspNetCore.WebSockets.dll",
                         "Microsoft.AspNetCore.WebUtilities.dll",
@@ -139,15 +122,8 @@ public class WebTemplate : ConsoleApplicationTemplate
                         "Microsoft.CodeAnalysis.dll",
                         "Microsoft.CodeAnalysis.Razor.dll",
                         "Microsoft.DotNet.PlatformAbstractions.dll",
-                        "Microsoft.EntityFrameworkCore.Abstractions.dll",
-                        "Microsoft.EntityFrameworkCore.Design.dll",
-                        "Microsoft.EntityFrameworkCore.dll",
-                        "Microsoft.EntityFrameworkCore.InMemory.dll",
-                        "Microsoft.EntityFrameworkCore.Relational.dll",
-                        "Microsoft.EntityFrameworkCore.SqlServer.dll",
                         "Microsoft.Extensions.Caching.Abstractions.dll",
                         "Microsoft.Extensions.Caching.Memory.dll",
-                        "Microsoft.Extensions.Caching.SqlServer.dll",
                         "Microsoft.Extensions.Configuration.Abstractions.dll",
                         "Microsoft.Extensions.Configuration.Binder.dll",
                         "Microsoft.Extensions.Configuration.CommandLine.dll",
@@ -194,17 +170,11 @@ public class WebTemplate : ConsoleApplicationTemplate
                         "Microsoft.IdentityModel.Logging.dll",
                         "Microsoft.IdentityModel.Protocols.dll",
                         "Microsoft.IdentityModel.Protocols.OpenIdConnect.dll",
-                        "Microsoft.IdentityModel.Protocols.WsFederation.dll",
                         "Microsoft.IdentityModel.Tokens.dll",
-                        "Microsoft.IdentityModel.Tokens.Saml.dll",
-                        "Microsoft.IdentityModel.Xml.dll",
                         "Microsoft.Net.Http.Headers.dll",
                         "Newtonsoft.Json.Bson.dll",
                         "Newtonsoft.Json.dll",
-                        "Remotion.Linq.dll",
-                        "System.Data.SqlClient.dll",
                         "System.IdentityModel.Tokens.Jwt.dll",
-                        "System.Interactive.Async.dll",
                         "System.IO.Pipelines.dll",
                         "System.Net.Http.Formatting.dll",
                         "System.Net.WebSockets.WebSocketProtocol.dll",