Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity.UI produce assemblies that are built with implementation assemblies instead of reference assemblies. #18323

Closed
JunTaoLuo opened this issue Jan 14, 2020 · 5 comments
Assignees
Milestone

Comments

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jan 14, 2020

We discovered in 3.1.1 that Identity.UI assemblies. Specifically V3.dll and V4.dll. Combined with the bug described in #17970, runtime errors due to not being able to load the correct assemblies will be produced. Though we are fixing the related issue, we should ensure that the Identity.UI assemblies are built correctly.

The reason why Identity.UI specifically does not build correctly is because the customized logic at https://github.com/dotnet/aspnetcore/blob/release/3.1/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj#L59-L65 where MSBuild is launched to directly invoke the BuildForUI target. This bypasses the logic that we need to trigger at https://github.com/dotnet/aspnetcore/blob/release/3.1/eng/targets/ResolveReferences.targets#L249-L276.

My recommendation would be to try separating out the project into two new project for each of the V3 and V4 content and building them separately in the same way we build the other UI packages. Then compose the final Identity.UI package with the dll produced in the V3 and V4 projects.

cc @pranavkm @mkArtakMSFT to triage.

@JunTaoLuo

This comment has been minimized.

Copy link
Contributor Author

@JunTaoLuo JunTaoLuo commented Jan 14, 2020

Here's the doc for the known issue in 3.1 https://github.com/aspnet/specs/pull/406/files

@Pilchie

This comment has been minimized.

Copy link
Member

@Pilchie Pilchie commented Jan 15, 2020

@mkArtakMSFT - we think this issue will block 3.1.2, and we need to work on a fix for it ASAP. Can you help us find someone who understands the build logic there to investigate ASAP?

@pranavkm

This comment has been minimized.

Copy link
Contributor

@pranavkm pranavkm commented Jan 15, 2020

Picking this up

@pranavkm pranavkm self-assigned this Jan 15, 2020
@Pilchie

This comment has been minimized.

Copy link
Member

@Pilchie Pilchie commented Jan 16, 2020

Thanks @pranavkm !

pranavkm added a commit that referenced this issue Jan 16, 2020
Fixes #18323
wtgodbe added a commit that referenced this issue Jan 17, 2020
* Use reference assemblies when compiling Razor views
Fixes #18323

* Avoid mixing runtime and ref assembly
@JunTaoLuo JunTaoLuo modified the milestones: 3.1.x, 3.1.2 Jan 17, 2020
@JunTaoLuo JunTaoLuo added the tell-mode label Jan 17, 2020
@JunTaoLuo

This comment has been minimized.

Copy link
Contributor Author

@JunTaoLuo JunTaoLuo commented Jan 17, 2020

The PR is merged so I'm closing. @pranavkm reopen if you need it to track something else.

@JunTaoLuo JunTaoLuo closed this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.