Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running dotnet watch run doesn't rebuild for changes to component specific CSS #25483

Closed
danroth27 opened this issue Sep 1, 2020 · 3 comments
Closed

Running dotnet watch run doesn't rebuild for changes to component specific CSS #25483

danroth27 opened this issue Sep 1, 2020 · 3 comments
Assignees
@pranavkm
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external)
Projects
ASP.NET Core Blazor & MVC 5.0.x
Milestone
5.0.0-rc2

Comments

@danroth27
Copy link
Member

danroth27 commented Sep 1, 2020 •
edited

Repro steps:

  • Install .NET 5 Preview 8
  • Create a new Blazor WebAssembly app
  • Run dotnet watch run on the new project
  • Modify Shared/MainLayout.razor.css

Expected result:

  • The app is rebuilt and restarted

Actual result:

  • The app is not rebuilt and restarted

Note: Running dotnet watch run should not rebuild and restart the app for changes to normal CSS files. These can just be reloaded in the browser.

@pranavkm
@mkArtakMSFT mkArtakMSFT added area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) labels Sep 1, 2020
@pranavkm
Copy link
Contributor

pranavkm commented Sep 1, 2020

We changed this fairly recently as part of fixing #22219. Could you grab a fairly new SDK and give this a try?

@danroth27
Copy link
Member Author

Still repros with 5.0.100-rc.1.20451.8

@danroth27 danroth27 mentioned this issue Sep 10, 2020
Closed
@danroth27 danroth27 added this to the 5.0.0-rc2 milestone Sep 10, 2020
@danroth27
Copy link
Member Author

Still repros with RC2

@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Sep 10, 2020
@mkArtakMSFT mkArtakMSFT added this to 5.0-rc2 (M2 Approval mode before: 9/9, QB: 9/14) in ASP.NET Core Blazor & MVC 5.0.x Sep 10, 2020
pranavkm added a commit that referenced this issue Sep 10, 2020
@pranavkm
Allow dotnet-watch to look for changes to .razor.css files
cd2d141 
Fixes #25483
@pranavkm pranavkm mentioned this issue Sep 10, 2020
Merged
@mkArtakMSFT mkArtakMSFT moved this from 5.0-rc2 (M2 Approval mode before: 9/9, QB: 9/14) to In progress in ASP.NET Core Blazor & MVC 5.0.x Sep 11, 2020
mkArtakMSFT pushed a commit that referenced this issue Sep 13, 2020
@pranavkm
Allow dotnet-watch to look for changes to .razor.css files (#25792)
ab5dfe5 
Fixes #25483
ASP.NET Core Blazor & MVC 5.0.x automation moved this from In progress to Done Sep 13, 2020
@msftbot msftbot bot added Done This issue has been fixed and removed Working labels Sep 13, 2020
@msftbot msftbot bot locked as resolved and limited conversation to collaborators Oct 13, 2020
dougbu pushed a commit to dougbu/razor-compiler that referenced this issue Nov 17, 2021
@pranavkm
Allow dotnet-watch to look for changes to .razor.css files (dotnet/as…
6f56889 
…pnetcore#25792)

Fixes dotnet/aspnetcore#25483

Commit migrated from dotnet/aspnetcore@ab5dfe537465
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external)
Projects
No open projects
ASP.NET Core Blazor & MVC 5.0.x
  
Done
Milestone
5.0.0-rc2
Development

No branches or pull requests
3 participants
@pranavkm @danroth27 @mkArtakMSFT