Under certain circumstances, the HttpLogging middleware does not follow the ResponseBodyLogLimit setting

[saber-wang]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

At this time, the buffer length may be longer than the ResponseBodyLogLimit setting

aspnetcore/src/Middleware/HttpLogging/src/ResponseBufferingStream.cs

Line 116 in 6a7bcda

BuffersExtensions.Write(this, buffer.Span);

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

net6.0

Anything else?

No response

[adityamandaleeka]

Triage: looks like this was an oversight.

There's a slice in a similar method just above this, but not in this one.

https://github.com/dotnet/aspnetcore/blob/6a7bcda42de7b98196b38924cc354216eba57c9b/src/Middleware/HttpLogging/src/ResponseBufferingStream.cs#LL86C47-L86C74

[patiqs]

Seems to be an easy fix.
Can we expect a fix in .NET6 ?

[patiqs]

There is an other inconvinient behaviour addition to this.
I have this simple code:

using Microsoft.AspNetCore.HttpLogging;

var builder = WebApplication.CreateBuilder(args);
builder.Services.AddHttpLogging(options =>
    options.LoggingFields = HttpLoggingFields.RequestPath
);

builder.Configuration.AddInMemoryCollection(new Dictionary<string, string>
{
    ["Logging:LogLevel:Microsoft.AspNetCore.HttpLogging.HttpLoggingMiddleware"] = "Information"
});

var app = builder.Build();

app.UseHttpLogging();

app.MapGet("/", () => "some response");

app.Run();

that generates these logs:

The response entry is useless here. Shouldn't be logged when it is turned off in options.LoggingFields