Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or make public pubternals for Http #11429

Merged
merged 3 commits into from
Jun 22, 2019
Merged

Remove or make public pubternals for Http #11429

merged 3 commits into from
Jun 22, 2019

Conversation

Tratcher
Copy link
Member

#11312, #2979 Removes Microsoft.AspNetCore.Builder.Internal and Microsoft.AspNetCore.Http.Internal by making some types fully public and others fully internal.
Public:

  • BindingAddress Move BindingAddress to public namespace #2979 - Used by Kestrel and HttpsRedirection
  • BufferingHelper - Often used by customers.
  • ApplicationBuilder - Used in many tests
  • FormFile & FormFileCollection - Used in many tests, hard to replace.
  • QueryCollection - Used by many tests

Internal:

  • DefaultConnectionInfo/HttpRequest/HttpResponse/WebSocketManager/ItemsDictionary - Only used internally by DefaultHttpContext.
  • RequestCookieCollection - Used by some tests but replaceable. (MVC, @pranavkm)
  • ResponseCookies

@Tratcher
Copy link
Member Author

Found a few more in in Http.Abstractions that all became internal:

  • HeaderSegment
  • HeaderSegmentCollection
  • ParsingHelpers

Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you write up the announcement for this make sure you mention some of the common alternatives to using these pubternal APIs

@Tratcher
Copy link
Member Author

Can we do one announcement for all of #11312? Doing one for every feature area gets noisy.

@Tratcher Tratcher merged commit 4ef204e into master Jun 22, 2019
@Tratcher Tratcher deleted the tratcher/pubternal branch June 22, 2019 00:56
@davidfowl
Copy link
Member

Sure

@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants