Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kestrel not use the modified Http Protocol #18322

Merged
merged 1 commit into from Jan 14, 2020
Merged

Conversation

@Tratcher
Copy link
Contributor

Tratcher commented Jan 13, 2020

#17975 @JamesNK found that when he was implementing grpc-web and pretending the HTTP/1.1 requests were HTTP/2, Kestrel's response generation logic would break. Kestrel should not use the user-modifiable request protocol field when generating responses, it will confuse the client.

@Tratcher Tratcher added this to the 5.0.0-preview1 milestone Jan 13, 2020
@Tratcher Tratcher requested review from halter73, JamesNK and jkotalik Jan 13, 2020
@Tratcher Tratcher requested a review from anurse as a code owner Jan 13, 2020
@Tratcher Tratcher self-assigned this Jan 13, 2020
Copy link
Member

JamesNK left a comment

LGTM

IMO not back-porting is fine. There is an easy workaround to reset it back to the original value for anyone crazy enough to run into this bug.

@Tratcher Tratcher added the auto-merge label Jan 13, 2020
@msftbot

This comment has been minimized.

Copy link

msftbot bot commented Jan 13, 2020

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 4 hours, a condition that will be fulfilled in about 2 hours 23 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
@msftbot msftbot bot merged commit 6dd3d6e into master Jan 14, 2020
18 checks passed
18 checks passed
WIP Ready for review
Details
aspnetcore-ci Build #20200113.8 had test failures
Details
aspnetcore-ci (Build Build: Linux ARM) Build Build: Linux ARM succeeded
Details
aspnetcore-ci (Build Build: Linux ARM64) Build Build: Linux ARM64 succeeded
Details
aspnetcore-ci (Build Build: Linux Musl ARM64) Build Build: Linux Musl ARM64 succeeded
Details
aspnetcore-ci (Build Build: Linux Musl x64) Build Build: Linux Musl x64 succeeded
Details
aspnetcore-ci (Build Build: Linux x64) Build Build: Linux x64 succeeded
Details
aspnetcore-ci (Build Build: Windows ARM) Build Build: Windows ARM succeeded
Details
aspnetcore-ci (Build Build: Windows x64/x86) Build Build: Windows x64/x86 succeeded
Details
aspnetcore-ci (Build Build: macOS) Build Build: macOS succeeded
Details
aspnetcore-ci (Build Code check) Build Code check succeeded
Details
aspnetcore-ci (Build Test: Linux Source Build) Build Test: Linux Source Build succeeded
Details
aspnetcore-ci (Build Test: Templates - Windows Server 2016 x64) Build Test: Templates - Windows Server 2016 x64 succeeded
Details
aspnetcore-ci (Build Test: Ubuntu 16.04 x64) Build Test: Ubuntu 16.04 x64 succeeded with issues
Details
aspnetcore-ci (Build Test: Windows Server 2016 x64) Build Test: Windows Server 2016 x64 succeeded
Details
aspnetcore-ci (Build Test: macOS 10.13) Build Test: macOS 10.13 succeeded
Details
aspnetcore-ci (Build Tests: Helix x64) Build Tests: Helix x64 succeeded
Details
license/cla All CLA requirements met.
Details
@Tratcher Tratcher deleted the tratcher/protocol branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.