From 2c6930cd2822340af6c3ac1044e9862790a636bb Mon Sep 17 00:00:00 2001 From: Safia Abdalla Date: Thu, 30 Jul 2020 14:13:45 -0700 Subject: [PATCH 1/3] Wait for component to mount before checking for output --- src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs b/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs index 7f62e86441f9..d34bd98ad501 100644 --- a/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs +++ b/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs @@ -46,6 +46,10 @@ public void BasicTestAppCanBeServed() public void CanRenderTextOnlyComponent() { var appElement = Browser.MountTestComponent(); + + new WebDriverWait(Browser, TimeSpan.FromSeconds(10)).Until( + driver => driver.FindElement(By.XPath("//*[contains(., 'Hello from TextOnlyComponent')]") != null)); + Assert.Equal("Hello from TextOnlyComponent", appElement.Text); } From 4296d2e7d573bd7997049a63d547ebcf076beb09 Mon Sep 17 00:00:00 2001 From: Safia Abdalla Date: Fri, 31 Jul 2020 10:10:44 -0700 Subject: [PATCH 2/3] Use Exists to check for element with timeout --- src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs b/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs index d34bd98ad501..54bc65de77ba 100644 --- a/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs +++ b/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs @@ -47,10 +47,7 @@ public void CanRenderTextOnlyComponent() { var appElement = Browser.MountTestComponent(); - new WebDriverWait(Browser, TimeSpan.FromSeconds(10)).Until( - driver => driver.FindElement(By.XPath("//*[contains(., 'Hello from TextOnlyComponent')]") != null)); - - Assert.Equal("Hello from TextOnlyComponent", appElement.Text); + Browser.Exists(By.XPath("//*[contains(., 'Hello from TextOnlyComponent')]")) } // This verifies that we've correctly configured the Razor language version via MSBuild. From d291817ee522e68300c7d02f3f1379e76688f992 Mon Sep 17 00:00:00 2001 From: Safia Abdalla Date: Fri, 31 Jul 2020 11:30:44 -0700 Subject: [PATCH 3/3] Update ComponentRenderingTest.cs --- src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs b/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs index 54bc65de77ba..6a105a5fffb3 100644 --- a/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs +++ b/src/Components/test/E2ETest/Tests/ComponentRenderingTest.cs @@ -47,7 +47,7 @@ public void CanRenderTextOnlyComponent() { var appElement = Browser.MountTestComponent(); - Browser.Exists(By.XPath("//*[contains(., 'Hello from TextOnlyComponent')]")) + Browser.Exists(By.XPath("//*[contains(., 'Hello from TextOnlyComponent')]")); } // This verifies that we've correctly configured the Razor language version via MSBuild.