Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update middleware that assumes UseRouting is called after them, for minimal hosting #35426

Merged
merged 14 commits into from Aug 24, 2021
Merged

Update middleware that assumes UseRouting is called after them, for minimal hosting #35426

merged 14 commits into from Aug 24, 2021

Conversation

BrennanConroy
Copy link
Member

Replaces #34991
Fixes #34146

This is just the ExceptionHandlerMiddleware for now. Getting the PR out for early feedback. Still needs at least 5 more tests and need to look at the Rewrite and StatusCode middleware as well.

@ghost ghost added the area-runtime label Aug 17, 2021
@BrennanConroy BrennanConroy mentioned this pull request Aug 17, 2021
Closed
@BrennanConroy
Copy link
Member Author

/backport to release/6.0-rc1

@github-actions
Copy link
Contributor

Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1160475626

@github-actions github-actions bot mentioned this pull request Aug 23, 2021
Merged
BrennanConroy and others added 2 commits August 23, 2021 18:29
@BrennanConroy @halter73
Apply suggestions from code review
44deaa1 
Co-authored-by: Stephen Halter <halter73@gmail.com>
@BrennanConroy
fb
f5670e1
davidfowl
davidfowl reviewed Aug 24, 2021
View reviewed changes
src/Middleware/Rewrite/src/RewriteBuilderExtensions.cs Outdated

// start a new middleware pipeline
var builder = app.New();
builder.UseMiddleware<RewriteMiddleware>(options);
Copy link
Member

@davidfowl davidfowl Aug 24, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
builder.UseMiddleware<RewriteMiddleware>(options);

This doesn't look right, why do we need to re-run the rewrite middleware on the new pipeline? Is this leftover?

@BrennanConroy BrennanConroy enabled auto-merge (squash) August 24, 2021 15:32
@BrennanConroy BrennanConroy merged commit f6452bf into main Aug 24, 2021
@BrennanConroy BrennanConroy deleted the brecon/useroutingmiddleware branch August 24, 2021 19:42
@ghost ghost added this to the 7.0-preview1 milestone Aug 24, 2021
@halter73 halter73 mentioned this pull request Jan 13, 2022
Closed
@halter73 halter73 mentioned this pull request Apr 28, 2022
Merged
@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kahbazi Kahbazi Kahbazi left review comments

@halter73 halter73 halter73 approved these changes

@davidfowl davidfowl davidfowl approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@Tratcher Tratcher Awaiting requested review from Tratcher

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware
Projects
None yet
Milestone
7.0-preview1
6 participants
@BrennanConroy @halter73 @davidfowl @Kahbazi @danmoseley @amcasey