Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RedisCache update that breaks usage against older redis servers #38927

Merged

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Dec 10, 2021

Fix RedisCache update that breaks usage against older redis servers

Add version checks and alternate API calls to support older redis versions

Description

6.0 changed from calling a deprecated redis API to a new one. Unfortunately the new API doesn't work on unsupported versions of redis which are still in common use.

Fixes #38715

Customer Impact

Unblocks customers stuck using old versions of redis.

Regression?

  • Yes
  • No

In 6.0

Risk

  • High
  • Medium
  • Low

Restoring the prior behavior

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@Tratcher Tratcher self-assigned this Dec 10, 2021
@ghost ghost added this to the 6.0.x milestone Dec 10, 2021
@ghost
Copy link

ghost commented Dec 10, 2021

Hi @Tratcher. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@Tratcher Tratcher added the Servicing-consider Shiproom approval is required for the issue label Dec 10, 2021
@ghost
Copy link

ghost commented Dec 10, 2021

Hi @Tratcher. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@Tratcher Tratcher marked this pull request as ready for review December 10, 2021 00:28
Copy link
Member

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure mine counts but backport looks good 👍

@Tratcher
Copy link
Member Author

Tratcher commented Jan 6, 2022

@dotnet/aspnet-build please merge.

@sebastienros sebastienros merged commit 85a0900 into dotnet:release/6.0 Jan 6, 2022
@Tratcher Tratcher deleted the tratcher/release/6.0/redis branch January 6, 2022 00:20
@Joseph-Anthony-King
Copy link

Hello team, I'm currently working on a .NET6 project using the latest versions of StackExchange.Redis and Redis Server 6.2.6 and I'm receiving the following error:

ERR Error running script (call to f_3915ee22fda531a1d5661f2523d0443fd35ff0a4): @user_script:2: @user_script: 2: Wrong number of args calling Redis command From Lua script

I believe this change is meant to address this issue and I see it's merged... is a release pending?

Thank you,
Joe

@ghost
Copy link

ghost commented Jan 30, 2022

Hi @Joseph-Anthony-King. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@dougbu
Copy link
Member

dougbu commented Jan 30, 2022

@Joseph-Anthony-King yes, the 6.0.2 release contains this fix and should be available soon. Please watch for announcements or check https://dotnet.microsoft.com/en-us/download/dotnet/6.0 occasionally.

@Joseph-Anthony-King
Copy link

Very cool, thank you for the update @dougbu !

@ghost
Copy link

ghost commented Jan 31, 2022

Hi @Joseph-Anthony-King. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants