-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RedisCache update that breaks usage against older redis servers #38927
Fix RedisCache update that breaks usage against older redis servers #38927
Conversation
Hi @Tratcher. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Hi @Tratcher. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure mine counts but backport looks good 👍
@dotnet/aspnet-build please merge. |
Hello team, I'm currently working on a .NET6 project using the latest versions of StackExchange.Redis and Redis Server 6.2.6 and I'm receiving the following error:
I believe this change is meant to address this issue and I see it's merged... is a release pending? Thank you, |
Hi @Joseph-Anthony-King. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
@Joseph-Anthony-King yes, the 6.0.2 release contains this fix and should be available soon. Please watch for announcements or check https://dotnet.microsoft.com/en-us/download/dotnet/6.0 occasionally. |
Very cool, thank you for the update @dougbu ! |
Hi @Joseph-Anthony-King. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Fix RedisCache update that breaks usage against older redis servers
Add version checks and alternate API calls to support older redis versions
Description
6.0 changed from calling a deprecated redis API to a new one. Unfortunately the new API doesn't work on unsupported versions of redis which are still in common use.
Fixes #38715
Customer Impact
Unblocks customers stuck using old versions of redis.
Regression?
In 6.0
Risk
Restoring the prior behavior
Verification
Packaging changes reviewed?