Add [GeneratedCode] for more RDG output #48377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `[GeneratedCode]` to more of the types emitted by the Request Delegate Generator.
martincostello
requested review from
Tratcher,
BrennanConroy,
halter73 and
captainsafia
as code owners
ghost
added
the
community-contribution
|
Thanks for your PR, @martincostello. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
Thanks for the submission. You'll need to regenerate the baselines in order for the tests to pass. Look in the TestBase class there is a field that you can set to true which will cause it to update all the baselines and then set it back to false and the tests should then pass. |
|
Thanks for pointing that out - I was just about to go looking at manually updating them before I saw your comment. Will push up the test fixes once I've gotten the repo setup nicely for debugging. |
Update the test baselines.
mitchdenny
approved these changes
May 24, 2023
|
Thanks for the contribution Martin! |
amcasey
added
area-minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add [GeneratedCode] for more RDG output
Add
[GeneratedCode]to more of the types emitted by the Request Delegate Generator.Description
Mark more of the code emitted by the Request Delegate Generator as non-user code so that it should be excluded from reports from code coverage tools.
I wasn't sure on what a good way to add a test for this is, so I haven't included a test change. Happy to add something if you have a preferred approach.
Fixes #48376.