From 8e5c52a337056c048a8c3129d4f8f1aca0a36c09 Mon Sep 17 00:00:00 2001 From: Mitch Denny Date: Thu, 13 Jul 2023 10:37:10 +1000 Subject: [PATCH 1/3] Tweak AddRazorPages trimming warning. --- src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs b/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs index 84dfd4b58b2c..9b2957e1f7df 100644 --- a/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs +++ b/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs @@ -253,7 +253,7 @@ private static IMvcCoreBuilder AddControllersWithViewsCore(IServiceCollection se /// To add services for controllers with views call . /// /// - [RequiresUnreferencedCode("Razor Pages does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Razor Pages does not currently support trimming or native AOT,", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddRazorPages(this IServiceCollection services) { ArgumentNullException.ThrowIfNull(services); From 8836540b4e10dc47585f3fca86d486196eed1993 Mon Sep 17 00:00:00 2001 From: Mitch Denny Date: Thu, 10 Aug 2023 14:21:55 +1000 Subject: [PATCH 2/3] Update other unreferenced code warnings. --- .../RazorComponentsServiceCollectionExtensions.cs | 2 +- .../ComponentServiceCollectionExtensions.cs | 2 +- .../src/IdentityServiceCollectionExtensions.cs | 4 ++-- .../src/SessionServiceCollectionExtensions.cs | 4 ++-- .../MvcRazorPagesMvcCoreBuilderExtensions.cs | 2 +- src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs | 14 +++++++------- .../src/SignalRDependencyInjectionExtensions.cs | 4 ++-- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/Components/Endpoints/src/DependencyInjection/RazorComponentsServiceCollectionExtensions.cs b/src/Components/Endpoints/src/DependencyInjection/RazorComponentsServiceCollectionExtensions.cs index d9bf2557d064..09fb81de6f23 100644 --- a/src/Components/Endpoints/src/DependencyInjection/RazorComponentsServiceCollectionExtensions.cs +++ b/src/Components/Endpoints/src/DependencyInjection/RazorComponentsServiceCollectionExtensions.cs @@ -28,7 +28,7 @@ public static class RazorComponentsServiceCollectionExtensions /// /// The service collection. /// An that can be used to further configure the Razor component services. - [RequiresUnreferencedCode("Razor Components does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Razor Components does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IRazorComponentsBuilder AddRazorComponents(this IServiceCollection services) { ArgumentNullException.ThrowIfNull(services); diff --git a/src/Components/Server/src/DependencyInjection/ComponentServiceCollectionExtensions.cs b/src/Components/Server/src/DependencyInjection/ComponentServiceCollectionExtensions.cs index 83a36b0ba669..bea90b2ec054 100644 --- a/src/Components/Server/src/DependencyInjection/ComponentServiceCollectionExtensions.cs +++ b/src/Components/Server/src/DependencyInjection/ComponentServiceCollectionExtensions.cs @@ -29,7 +29,7 @@ public static class ComponentServiceCollectionExtensions /// The . /// A callback to configure . /// An that can be used to further customize the configuration. - [RequiresUnreferencedCode("Server-side Blazor does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Server-side Blazor does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IServerSideBlazorBuilder AddServerSideBlazor(this IServiceCollection services, Action? configure = null) { var builder = new DefaultServerSideBlazorBuilder(services); diff --git a/src/Identity/Core/src/IdentityServiceCollectionExtensions.cs b/src/Identity/Core/src/IdentityServiceCollectionExtensions.cs index 0fd66e73a05f..8b547dc148cd 100644 --- a/src/Identity/Core/src/IdentityServiceCollectionExtensions.cs +++ b/src/Identity/Core/src/IdentityServiceCollectionExtensions.cs @@ -27,7 +27,7 @@ public static class IdentityServiceCollectionExtensions /// The type representing a Role in the system. /// The services available in the application. /// An for creating and configuring the identity system. - [RequiresUnreferencedCode("Identity middleware does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Identity middleware does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IdentityBuilder AddIdentity( this IServiceCollection services) where TUser : class @@ -42,7 +42,7 @@ public static class IdentityServiceCollectionExtensions /// The services available in the application. /// An action to configure the . /// An for creating and configuring the identity system. - [RequiresUnreferencedCode("Identity middleware does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Identity middleware does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IdentityBuilder AddIdentity( this IServiceCollection services, Action setupAction) diff --git a/src/Middleware/Session/src/SessionServiceCollectionExtensions.cs b/src/Middleware/Session/src/SessionServiceCollectionExtensions.cs index c6b6183faeb4..637f80ed00af 100644 --- a/src/Middleware/Session/src/SessionServiceCollectionExtensions.cs +++ b/src/Middleware/Session/src/SessionServiceCollectionExtensions.cs @@ -18,7 +18,7 @@ public static class SessionServiceCollectionExtensions /// /// The to add the services to. /// The so that additional calls can be chained. - [RequiresUnreferencedCode("Session State middleware does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Session State middleware does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IServiceCollection AddSession(this IServiceCollection services) { ArgumentNullException.ThrowIfNull(services); @@ -34,7 +34,7 @@ public static IServiceCollection AddSession(this IServiceCollection services) /// The to add the services to. /// The session options to configure the middleware with. /// The so that additional calls can be chained. - [RequiresUnreferencedCode("Session State middleware does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Session State middleware does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IServiceCollection AddSession(this IServiceCollection services, Action configure) { ArgumentNullException.ThrowIfNull(services); diff --git a/src/Mvc/Mvc.RazorPages/src/DependencyInjection/MvcRazorPagesMvcCoreBuilderExtensions.cs b/src/Mvc/Mvc.RazorPages/src/DependencyInjection/MvcRazorPagesMvcCoreBuilderExtensions.cs index 3efedae7191a..be186673e1d1 100644 --- a/src/Mvc/Mvc.RazorPages/src/DependencyInjection/MvcRazorPagesMvcCoreBuilderExtensions.cs +++ b/src/Mvc/Mvc.RazorPages/src/DependencyInjection/MvcRazorPagesMvcCoreBuilderExtensions.cs @@ -27,7 +27,7 @@ public static class MvcRazorPagesMvcCoreBuilderExtensions /// /// The . /// The . - [RequiresUnreferencedCode("Razor Pages does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Razor Pages does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcCoreBuilder AddRazorPages(this IMvcCoreBuilder builder) { ArgumentNullException.ThrowIfNull(builder); diff --git a/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs b/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs index 9b2957e1f7df..1d240dccc11a 100644 --- a/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs +++ b/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs @@ -27,7 +27,7 @@ public static class MvcServiceCollectionExtensions /// /// The to add services to. /// An that can be used to further configure the MVC services. - [RequiresUnreferencedCode("MVC does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("MVC does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddMvc(this IServiceCollection services) { ArgumentNullException.ThrowIfNull(services); @@ -42,7 +42,7 @@ public static IMvcBuilder AddMvc(this IServiceCollection services) /// The to add services to. /// An to configure the provided . /// An that can be used to further configure the MVC services. - [RequiresUnreferencedCode("MVC does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("MVC does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddMvc(this IServiceCollection services, Action setupAction) { ArgumentNullException.ThrowIfNull(services); @@ -79,7 +79,7 @@ public static IMvcBuilder AddMvc(this IServiceCollection services, Action /// - [RequiresUnreferencedCode("MVC does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("MVC does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddControllers(this IServiceCollection services) { ArgumentNullException.ThrowIfNull(services); @@ -114,7 +114,7 @@ public static IMvcBuilder AddControllers(this IServiceCollection services) /// on the resulting builder. /// /// - [RequiresUnreferencedCode("MVC does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("MVC does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddControllers(this IServiceCollection services, Action? configure) { ArgumentNullException.ThrowIfNull(services); @@ -172,7 +172,7 @@ private static IMvcCoreBuilder AddControllersCore(IServiceCollection services) /// To add services for pages call . /// /// - [RequiresUnreferencedCode("MVC does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("MVC does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddControllersWithViews(this IServiceCollection services) { ArgumentNullException.ThrowIfNull(services); @@ -205,7 +205,7 @@ public static IMvcBuilder AddControllersWithViews(this IServiceCollection servic /// To add services for pages call . /// /// - [RequiresUnreferencedCode("MVC does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("MVC does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddControllersWithViews(this IServiceCollection services, Action? configure) { ArgumentNullException.ThrowIfNull(services); @@ -284,7 +284,7 @@ public static IMvcBuilder AddRazorPages(this IServiceCollection services) /// To add services for controllers with views call . /// /// - [RequiresUnreferencedCode("Razor Pages does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("Razor Pages does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddRazorPages(this IServiceCollection services, Action? configure) { ArgumentNullException.ThrowIfNull(services); diff --git a/src/SignalR/server/SignalR/src/SignalRDependencyInjectionExtensions.cs b/src/SignalR/server/SignalR/src/SignalRDependencyInjectionExtensions.cs index ed613ec73f96..20a3c6d2ab36 100644 --- a/src/SignalR/server/SignalR/src/SignalRDependencyInjectionExtensions.cs +++ b/src/SignalR/server/SignalR/src/SignalRDependencyInjectionExtensions.cs @@ -35,7 +35,7 @@ public static ISignalRServerBuilder AddHubOptions(this ISignalRServerBuild /// /// The to add services to. /// An that can be used to further configure the SignalR services. - [RequiresUnreferencedCode("SignalR does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("SignalR does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static ISignalRServerBuilder AddSignalR(this IServiceCollection services) { ArgumentNullException.ThrowIfNull(services); @@ -55,7 +55,7 @@ public static ISignalRServerBuilder AddSignalR(this IServiceCollection services) /// The to add services to. /// An to configure the provided . /// An that can be used to further configure the SignalR services. - [RequiresUnreferencedCode("SignalR does not currently support native AOT.", Url = "https://aka.ms/aspnet/nativeaot")] + [RequiresUnreferencedCode("SignalR does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static ISignalRServerBuilder AddSignalR(this IServiceCollection services, Action configure) { ArgumentNullException.ThrowIfNull(services); From aba5b805a97443332bf38c736eef21feb8966169 Mon Sep 17 00:00:00 2001 From: Eric Erhardt Date: Thu, 10 Aug 2023 10:16:04 -0500 Subject: [PATCH 3/3] Update src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs --- src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs b/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs index 1d240dccc11a..c1d61926f2f1 100644 --- a/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs +++ b/src/Mvc/Mvc/src/MvcServiceCollectionExtensions.cs @@ -253,7 +253,7 @@ private static IMvcCoreBuilder AddControllersWithViewsCore(IServiceCollection se /// To add services for controllers with views call . /// /// - [RequiresUnreferencedCode("Razor Pages does not currently support trimming or native AOT,", Url = "https://aka.ms/aspnet/trimming")] + [RequiresUnreferencedCode("Razor Pages does not currently support trimming or native AOT.", Url = "https://aka.ms/aspnet/trimming")] public static IMvcBuilder AddRazorPages(this IServiceCollection services) { ArgumentNullException.ThrowIfNull(services);