From f92f4586b2fc99b242362bb3a95049979fc901f8 Mon Sep 17 00:00:00 2001 From: Dennis Haney Date: Thu, 19 Oct 2023 10:39:01 +0200 Subject: [PATCH 1/4] doc(Update DenyAnonymousAuthorizationRequirement): Actual behaviour is different than class name --- .../Core/src/DenyAnonymousAuthorizationRequirement.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs b/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs index 6e8729dc92e1..7c519025449a 100644 --- a/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs +++ b/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs @@ -9,6 +9,7 @@ namespace Microsoft.AspNetCore.Authorization.Infrastructure; /// /// Implements an and /// which requires the current user must be authenticated. +/// Unlike what the name of the class implies, where you would expect failure if not authenticated, it instead succeeds if you are authenticated. /// public class DenyAnonymousAuthorizationRequirement : AuthorizationHandler, IAuthorizationRequirement { From d272806a25ab144c4b35603d39c9f1b19cb70c43 Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Wed, 8 Nov 2023 18:04:51 -0800 Subject: [PATCH 2/4] Update src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs --- .../Core/src/DenyAnonymousAuthorizationRequirement.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs b/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs index 7c519025449a..571a8ba9e390 100644 --- a/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs +++ b/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs @@ -9,7 +9,7 @@ namespace Microsoft.AspNetCore.Authorization.Infrastructure; /// /// Implements an and /// which requires the current user must be authenticated. -/// Unlike what the name of the class implies, where you would expect failure if not authenticated, it instead succeeds if you are authenticated. +/// This calls for authenticated users. Like all built-in requirements, it never calls . The produces a failed when any requirement has not succeeded even if other requirements have succeeded and no requirement has explicitly failed. /// public class DenyAnonymousAuthorizationRequirement : AuthorizationHandler, IAuthorizationRequirement { From 6eb554d6961c55bc264825ca624f09f157ad32bb Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Wed, 8 Nov 2023 18:06:00 -0800 Subject: [PATCH 3/4] Update src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs --- .../Core/src/DenyAnonymousAuthorizationRequirement.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs b/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs index 571a8ba9e390..eeadc4203e49 100644 --- a/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs +++ b/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs @@ -9,7 +9,8 @@ namespace Microsoft.AspNetCore.Authorization.Infrastructure; /// /// Implements an and /// which requires the current user must be authenticated. -/// This calls for authenticated users. Like all built-in requirements, it never calls . The produces a failed when any requirement has not succeeded even if other requirements have succeeded and no requirement has explicitly failed. +/// This calls for authenticated users. Like all built-in requirements, it never calls . +/// The produces a failed when any requirement has not succeeded even if other requirements have succeeded and no requirement has explicitly failed. /// public class DenyAnonymousAuthorizationRequirement : AuthorizationHandler, IAuthorizationRequirement { From 370a13ace06d7aa366a04977107b0f85c7762bcd Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Thu, 9 Nov 2023 14:34:55 -0800 Subject: [PATCH 4/4] Update src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs --- .../Core/src/DenyAnonymousAuthorizationRequirement.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs b/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs index eeadc4203e49..69f5d308175a 100644 --- a/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs +++ b/src/Security/Authorization/Core/src/DenyAnonymousAuthorizationRequirement.cs @@ -7,10 +7,10 @@ namespace Microsoft.AspNetCore.Authorization.Infrastructure; /// -/// Implements an and -/// which requires the current user must be authenticated. -/// This calls for authenticated users. Like all built-in requirements, it never calls . -/// The produces a failed when any requirement has not succeeded even if other requirements have succeeded and no requirement has explicitly failed. +/// Implements an and which requires the current user must be authenticated. +/// This calls for authenticated users. Like all built-in requirements, +/// it never calls . The produces a failed +/// when any requirement has not succeeded even if other requirements have succeeded, and no requirement has explicitly failed. /// public class DenyAnonymousAuthorizationRequirement : AuthorizationHandler, IAuthorizationRequirement {