Skip to content

[Dependency update] Update SDK to 9.0.100-alpha.1.23618.1 #52877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

[Dependency update] Update SDK to 9.0.100-alpha.1.23618.1 #52877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"sdk": {
"version": "9.0.100-alpha.1.23608.3"
"version": "9.0.100-alpha.1.23618.1"
},
"tools": {
"dotnet": "9.0.100-alpha.1.23608.3",
"dotnet": "9.0.100-alpha.1.23618.1",
"runtimes": {
"dotnet/x86": [
"$(MicrosoftNETCoreBrowserDebugHostTransportVersion)"
Expand Down
1 change: 0 additions & 1 deletion src/Components/Server/src/Circuits/CircuitHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,6 @@ private async Task TryNotifyClientErrorAsync(IClientProxy client, string error,
internal Task UpdateRootComponents(
RootComponentOperationBatch operationBatch,
ProtectedPrerenderComponentApplicationStore store,
IServerComponentDeserializer serverComponentDeserializer,
Copy link
Member

@sebastienros sebastienros Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it related to the SDK update?

Copy link
Member Author

@javiercn javiercn Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the analyzer flagged it, and wasn't being used

CancellationToken cancellation)
{
Log.UpdateRootComponentsStarted(_logger);
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Server/src/ComponentHub.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ public async Task UpdateRootComponents(string serializedComponentOperations, str
new ProtectedPrerenderComponentApplicationStore(applicationState, _dataProtectionProvider) :
new ProtectedPrerenderComponentApplicationStore(_dataProtectionProvider);

_ = circuitHost.UpdateRootComponents(operations, store, _serverComponentSerializer, Context.ConnectionAborted);
_ = circuitHost.UpdateRootComponents(operations, store, Context.ConnectionAborted);
}

public async ValueTask<bool> ConnectCircuit(string circuitIdSecret)
Expand Down
9 changes: 3 additions & 6 deletions src/Components/Server/test/Circuits/CircuitHostTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,7 @@ private async Task AddComponentAsync<TComponent>(CircuitHost circuitHost, int ss
};

// Add component
await circuitHost.UpdateRootComponents(
new() { Operations = [addOperation] }, null, CreateDeserializer(), CancellationToken.None);
await circuitHost.UpdateRootComponents(new() { Operations = [addOperation] }, null, CancellationToken.None);
}

private async Task UpdateComponentAsync<TComponent>(CircuitHost circuitHost, int ssrComponentId, Dictionary<string, object> parameters = null, string componentKey = "")
Expand All @@ -615,8 +614,7 @@ private async Task UpdateComponentAsync<TComponent>(CircuitHost circuitHost, int
};

// Update component
await circuitHost.UpdateRootComponents(
new() { Operations = [updateOperation] }, null, CreateDeserializer(), CancellationToken.None);
await circuitHost.UpdateRootComponents(new() { Operations = [updateOperation] }, null, CancellationToken.None);
}

private async Task RemoveComponentAsync(CircuitHost circuitHost, int ssrComponentId)
Expand All @@ -628,8 +626,7 @@ private async Task RemoveComponentAsync(CircuitHost circuitHost, int ssrComponen
};

// Remove component
await circuitHost.UpdateRootComponents(
new() { Operations = [removeOperation] }, null, CreateDeserializer(), CancellationToken.None);
await circuitHost.UpdateRootComponents(new() { Operations = [removeOperation] }, null, CancellationToken.None);
}

private ProtectedPrerenderComponentApplicationStore CreateStore()
Expand Down