Skip to content

Note fire-and-forget status of HubConnection event tasks - #57779

Merged
BrennanConroy merged 3 commits into
dotnet:mainfrom
Smaug123:hubconnection-fire-and-forget
Jan 22, 2025
Merged

Note fire-and-forget status of HubConnection event tasks#57779
BrennanConroy merged 3 commits into
dotnet:mainfrom
Smaug123:hubconnection-fire-and-forget

Conversation

@Smaug123

@Smaug123 Smaug123 commented Sep 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Document fire-and-forget status of HubConnection event tasks

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Document the fate of the Tasks associated with HubConnection events.

Description

Verification:

Fixes #57777 .

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Sep 10, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Sep 10, 2024
@dotnet-policy-service dotnet-policy-service Bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 18, 2024
BrennanConroy
BrennanConroy reviewed Jan 17, 2025
View reviewed changes
Comment thread src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs Outdated
@BrennanConroy BrennanConroy removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 22, 2025
@BrennanConroy
BrennanConroy merged commit e685d09 into dotnet:main Jan 22, 2025
@dotnet-policy-service dotnet-policy-service Bot added this to the 10.0-preview1 milestone Jan 22, 2025
@Smaug123
Smaug123 deleted the hubconnection-fire-and-forget branch February 6, 2025 20:51
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
@Smaug123 @captainsafia
Note fire-and-forget status of HubConnection event tasks (#57779)
af1e22f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes
@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees

@BrennanConroy BrennanConroy

Labels

area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

10.0-preview1

Development

Successfully merging this pull request may close these issues.

HubConnection docs don't specify what happens to Tasks spawned on events

3 participants

@Smaug123 @BrennanConroy @adityamandaleeka