From bdb20412b818694a820d2e22d551478b2b1acb83 Mon Sep 17 00:00:00 2001 From: Mackinnon Buck Date: Thu, 27 Mar 2025 11:09:17 -0700 Subject: [PATCH 1/2] Quarantine EnhancedNavigationScrollBehavesSameAsBrowserOnBackwardsForwardsAction --- .../E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs b/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs index a0b526805783..5b58a3be666c 100644 --- a/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs +++ b/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs @@ -722,10 +722,10 @@ public void EnhancedNavigationScrollBehavesSameAsBrowserOnNavigation(bool enable } [Theory] - [InlineData(false, false, false)] // https://github.com/dotnet/aspnetcore/issues/60875 + // [InlineData(false, false, false)] // https://github.com/dotnet/aspnetcore/issues/60875 [InlineData(false, true, false)] - [InlineData(true, true, false)] // https://github.com/dotnet/aspnetcore/issues/60875 - [InlineData(true, false, false)] + // [InlineData(true, true, false)] // https://github.com/dotnet/aspnetcore/issues/60875 + // [InlineData(true, false, false)] // https://github.com/dotnet/aspnetcore/issues/60875 // [InlineData(false, false, true)] programmatic navigation doesn't work without enhanced navigation [InlineData(false, true, true)] [InlineData(true, true, true)] From b1cb7857f983abf92b34f47949fc0fb598a9c200 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Fri, 28 Mar 2025 08:42:37 +0100 Subject: [PATCH 2/2] Uncomment test case with `EnhancedNavigation: true` Only tests with browser navigation are prone to failing. --- .../test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs b/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs index 5b58a3be666c..dff07dabe683 100644 --- a/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs +++ b/src/Components/test/E2ETest/ServerRenderingTests/EnhancedNavigationTest.cs @@ -724,7 +724,7 @@ public void EnhancedNavigationScrollBehavesSameAsBrowserOnNavigation(bool enable [Theory] // [InlineData(false, false, false)] // https://github.com/dotnet/aspnetcore/issues/60875 [InlineData(false, true, false)] - // [InlineData(true, true, false)] // https://github.com/dotnet/aspnetcore/issues/60875 + [InlineData(true, true, false)] // [InlineData(true, false, false)] // https://github.com/dotnet/aspnetcore/issues/60875 // [InlineData(false, false, true)] programmatic navigation doesn't work without enhanced navigation [InlineData(false, true, true)]