From 81a826e3f535a716a6aa95e4d15422b292784e8e Mon Sep 17 00:00:00 2001 From: Tom Deseyn Date: Tue, 20 May 2025 12:38:31 +0200 Subject: [PATCH 1/2] eng/build.sh: support --warnaserror flag. --- eng/build.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/eng/build.sh b/eng/build.sh index fa217f24ec59..a65298735024 100755 --- a/eng/build.sh +++ b/eng/build.sh @@ -37,6 +37,7 @@ runtime_source_feed='' runtime_source_feed_key='' source_build='' product_build='' +warn_as_error=true if [ "$(uname)" = "Darwin" ]; then target_os_name='osx' @@ -86,6 +87,7 @@ Options: --binarylog|-bl Use a binary logger --excludeCIBinarylog Don't output binary log by default in CI builds (short: -nobl). --verbosity|-v MSBuild verbosity: q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic] + --warnaserror Sets warnaserror msbuild parameter: 'true' or 'false' --runtime-source-feed Additional feed that can be used when downloading .NET runtimes and SDKs --runtime-source-feed-key Key for feed that can be used when downloading .NET runtimes and SDKs @@ -259,6 +261,11 @@ while [[ $# -gt 0 ]]; do -productbuild|-product-build|-pb) product_build=true ;; + -warnaserror) + shift + [ -z "${1:-}" ] && __error "Missing value for parameter --warnaserror" && __usage + warn_as_error="${1:-}" + ;; *) msbuild_args[${#msbuild_args[*]}]="$1" ;; From 94e0faf9c45043833175019a1318c2b28edc6c00 Mon Sep 17 00:00:00 2001 From: Tom Deseyn Date: Tue, 20 May 2025 16:31:27 +0200 Subject: [PATCH 2/2] Update eng/build.sh Co-authored-by: Viktor Hofer --- eng/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/build.sh b/eng/build.sh index a65298735024..5bbb20c685c9 100755 --- a/eng/build.sh +++ b/eng/build.sh @@ -87,7 +87,7 @@ Options: --binarylog|-bl Use a binary logger --excludeCIBinarylog Don't output binary log by default in CI builds (short: -nobl). --verbosity|-v MSBuild verbosity: q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic] - --warnaserror Sets warnaserror msbuild parameter: 'true' or 'false' + --warnAsError Sets warnaserror msbuild parameter: 'true' or 'false' --runtime-source-feed Additional feed that can be used when downloading .NET runtimes and SDKs --runtime-source-feed-key Key for feed that can be used when downloading .NET runtimes and SDKs