From ad352af11daa4a111fa610a1065a1a80e5a549f5 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 10 Oct 2025 19:22:17 +0000
Subject: [PATCH 1/4] Initial plan


From ef4f2132b3318e4217403688066e2e88e704302d Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 10 Oct 2025 19:30:16 +0000
Subject: [PATCH 2/4] Optimize _MvcCopyDependencyFiles target to reduce Copy
 task invocations

Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
---
 .../src/Microsoft.AspNetCore.Mvc.Testing.targets         | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets b/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
index ef11dc59f2a1..12983a5f1b11 100644
--- a/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
+++ b/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
@@ -70,11 +70,16 @@
         <_CreateSymbolicLinksForMvcCopyDependencyFilesIfPossible Condition="'$(_CreateSymbolicLinksMvcCopyDependencyFilesIfPossible)' == ''">$(CreateSymbolicLinksForCopyFilesToOutputDirectoryIfPossible)</_CreateSymbolicLinksForMvcCopyDependencyFilesIfPossible>
     </PropertyGroup>
 
-    <Copy SourceFiles="%(DepsFilePaths.FullPath)"
+    <ItemGroup>
+      <_DepsFilesToCopy Include="@(DepsFilePaths)" Condition="Exists('%(DepsFilePaths.FullPath)')" />
+    </ItemGroup>
+
+    <Copy SourceFiles="@(_DepsFilesToCopy)"
        DestinationFolder="$(OutDir)"
        UseHardlinksIfPossible="$(_CreateHardLinksForMvcCopyDependencyFilesIfPossible)"
        UseSymboliclinksIfPossible="$(_CreateSymbolicLinksForMvcCopyDependencyFilesIfPossible)"
-       Condition="Exists('%(DepsFilePaths.FullPath)')" />
+       SkipUnchangedFiles="true"
+       Condition="'@(_DepsFilesToCopy)' != ''" />
   </Target>
 
 </Project>

From f00b5da38483a783434741a40107474586f31626 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 10 Oct 2025 19:35:45 +0000
Subject: [PATCH 3/4] Also optimize _GeneratePublishTestManifest target for
 consistency

Co-authored-by: joperezr <13854455+joperezr@users.noreply.github.com>
---
 .../src/Microsoft.AspNetCore.Mvc.Testing.targets           | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets b/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
index 12983a5f1b11..5ce0949173da 100644
--- a/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
+++ b/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
@@ -55,7 +55,12 @@
     </ItemGroup>
 
     <GenerateMvcTestManifestTask ManifestPath="$(PublishDir)MvcTestingAppManifest.json" Projects="@(_PublishManifestProjects)" />
-    <Copy SourceFiles="%(_DepsFileToPublish.FullPath)" DestinationFolder="$(PublishDir)" Condition="Exists('%(_DepsFileToPublish.FullPath)')" />
+    
+    <ItemGroup>
+      <_DepsFilesToPublish Include="@(_DepsFileToPublish)" Condition="Exists('%(_DepsFileToPublish.FullPath)')" />
+    </ItemGroup>
+    
+    <Copy SourceFiles="@(_DepsFilesToPublish)" DestinationFolder="$(PublishDir)" SkipUnchangedFiles="true" Condition="'@(_DepsFilesToPublish)' != ''" />
   </Target>
 
   <Target Name="_MvcCopyDependencyFiles" AfterTargets="Build;_ResolveMvcTestProjectReferences" Condition="'$(TargetFramework)'!=''">

From e13b85dc92f8eefc5a4656298aebfb3b67c3391b Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 10 Oct 2025 20:07:22 +0000
Subject: [PATCH 4/4] Fix MSBuild item list handling and condition syntax per
 review feedback

- Use new item list _DepsFilesToPublishResolved from FullPath metadata instead of overwriting _DepsFileToPublish
- Change condition syntax from '@(list) != empty' to '@(list->Count()) > 0' to avoid list rendering overhead

Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
---
 .../src/Microsoft.AspNetCore.Mvc.Testing.targets            | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets b/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
index 5ce0949173da..0a8b9bbf7577 100644
--- a/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
+++ b/src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.targets
@@ -57,10 +57,10 @@
     <GenerateMvcTestManifestTask ManifestPath="$(PublishDir)MvcTestingAppManifest.json" Projects="@(_PublishManifestProjects)" />
     
     <ItemGroup>
-      <_DepsFilesToPublish Include="@(_DepsFileToPublish)" Condition="Exists('%(_DepsFileToPublish.FullPath)')" />
+      <_DepsFilesToPublishResolved Include="%(_DepsFileToPublish.FullPath)" Condition="Exists('%(_DepsFileToPublish.FullPath)')" />
     </ItemGroup>
     
-    <Copy SourceFiles="@(_DepsFilesToPublish)" DestinationFolder="$(PublishDir)" SkipUnchangedFiles="true" Condition="'@(_DepsFilesToPublish)' != ''" />
+    <Copy SourceFiles="@(_DepsFilesToPublishResolved)" DestinationFolder="$(PublishDir)" SkipUnchangedFiles="true" Condition="@(_DepsFilesToPublishResolved->Count()) > 0" />
   </Target>
 
   <Target Name="_MvcCopyDependencyFiles" AfterTargets="Build;_ResolveMvcTestProjectReferences" Condition="'$(TargetFramework)'!=''">
@@ -84,7 +84,7 @@
        UseHardlinksIfPossible="$(_CreateHardLinksForMvcCopyDependencyFilesIfPossible)"
        UseSymboliclinksIfPossible="$(_CreateSymbolicLinksForMvcCopyDependencyFilesIfPossible)"
        SkipUnchangedFiles="true"
-       Condition="'@(_DepsFilesToCopy)' != ''" />
+       Condition="@(_DepsFilesToCopy->Count()) > 0" />
   </Target>
 
 </Project>