From 1d687e1d38034eddddba8793dc1a888f31ca71fb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 20 Oct 2025 17:35:45 +0000 Subject: [PATCH 1/5] Initial plan From bc291e1ca57a3ae2201f6bb65cff1925e5db91f6 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 20 Oct 2025 17:45:18 +0000 Subject: [PATCH 2/5] Update ExpireTimeSpan XML documentation to clarify usage Co-authored-by: MackinnonBuck <10456961+MackinnonBuck@users.noreply.github.com> --- .../Authentication/Cookies/src/CookieAuthenticationOptions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs b/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs index dce34db1cae8..e098b51991de 100644 --- a/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs +++ b/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs @@ -128,8 +128,8 @@ public CookieBuilder Cookie /// even if it is passed to the server after the browser should have purged it. /// /// - /// This is separate from the value of , which specifies - /// how long the browser will keep the cookie. + /// This property should be used instead of . The handler will set the + /// cookie expiration time based on this value when is true. /// /// public TimeSpan ExpireTimeSpan { get; set; } From 9114d1799bb77889dea7a357cd77cd6c0bf8b054 Mon Sep 17 00:00:00 2001 From: Mackinnon Buck Date: Mon, 20 Oct 2025 12:05:50 -0700 Subject: [PATCH 3/5] Simplify documentation for `ExpireTimeSpan` property --- .../Authentication/Cookies/src/CookieAuthenticationOptions.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs b/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs index e098b51991de..f1b660d762bb 100644 --- a/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs +++ b/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs @@ -128,8 +128,7 @@ public CookieBuilder Cookie /// even if it is passed to the server after the browser should have purged it. /// /// - /// This property should be used instead of . The handler will set the - /// cookie expiration time based on this value when is true. + /// This property should be used instead of . /// /// public TimeSpan ExpireTimeSpan { get; set; } From 01ff0062047716ddae350bb9330602ab692d014c Mon Sep 17 00:00:00 2001 From: Mackinnon Buck Date: Tue, 21 Oct 2025 12:28:05 -0700 Subject: [PATCH 4/5] Update XML docs --- .../Authentication/Cookies/src/CookieAuthenticationOptions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs b/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs index f1b660d762bb..b792aaba8fd0 100644 --- a/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs +++ b/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs @@ -128,7 +128,7 @@ public CookieBuilder Cookie /// even if it is passed to the server after the browser should have purged it. /// /// - /// This property should be used instead of . + /// This property should be used instead of , which is ignored. /// /// public TimeSpan ExpireTimeSpan { get; set; } From 6000f24fa496668c235aead18c0f564adcd54e93 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 22 Oct 2025 23:16:19 +0000 Subject: [PATCH 5/5] Use CookieBuilder.Expiration instead of CookieOptions.Expires in XML documentation Co-authored-by: MackinnonBuck <10456961+MackinnonBuck@users.noreply.github.com> --- .../Authentication/Cookies/src/CookieAuthenticationOptions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs b/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs index b792aaba8fd0..1655b90552a0 100644 --- a/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs +++ b/src/Security/Authentication/Cookies/src/CookieAuthenticationOptions.cs @@ -128,7 +128,7 @@ public CookieBuilder Cookie /// even if it is passed to the server after the browser should have purged it. /// /// - /// This property should be used instead of , which is ignored. + /// This property should be used instead of , which is ignored. /// /// public TimeSpan ExpireTimeSpan { get; set; }