Remove redundant IsElementStale method and use WebDriverExtensions.IsStale #64549
+1
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Contributor
|
Greetings! You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo! |
…Stale Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix NavigateTo API when enhanced nav is disabled
Remove redundant IsElementStale method and use WebDriverExtensions.IsStale
Nov 27, 2025
Copilot finished work on behalf of
javiercn
November 27, 2025 13:11
ilonatommy
approved these changes
Nov 27, 2025
javiercn
approved these changes
Nov 27, 2025
javiercn
merged commit 485495f
into
javiercn/forward-port-missing-52267-fix-to-10
16 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant IsElementStale method and use WebDriverExtensions.IsStale
Cleanup: Remove duplicate
IsElementStaleand use existingWebDriverExtensions.IsStale()Description
Addresses review feedback from #64542. The
IsElementStalemethod inEnhancedNavigationTestUtil.csduplicates functionality already available inWebDriverExtensions.IsStale().Changes:
IsElementStalefromEnhancedNavigationTestUtil.csCanPerformNavigateToFromInteractiveEventHandlertest to useelement.IsStale()extension methodEnhancedNavigationTest.csCustomer Impact
None - test infrastructure cleanup only.
Regression?
Risk
Test-only change, no production code affected.
Verification
Packaging changes reviewed?
When servicing release/2.3
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.