provide xml doc on IFormFile.FileName for user attention
#64660
Merged
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeagleGross
requested review from
BrennanConroy,
captainsafia and
halter73
as code owners
github-actions
bot
added
the
area-networking
Copilot finished reviewing on behalf of
DeagleGross
December 5, 2025 10:18
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds important security guidance to the IFormFile.FileName property documentation, warning developers about potential security risks when using the file name from untrusted sources. The documentation aligns with official ASP.NET Core security best practices.
- Adds XML
<remarks>section warning against usingFileNamefor anything other than display/logging - Includes security guidance about HTML encoding and path manipulation risks
- Provides a code example demonstrating how to sanitize file names
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
BrennanConroy
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describes that
FileNameshould not be used directly as per doc. Raises user attention when usingFilenamedirectly