Revert "Pass RequestAborted cancellation token to WriteAsJsonAsync in DefaultProblemDetailsWriter"#66811
Open
Youssef1313 wants to merge 1 commit into
Conversation
… Default…" This reverts commit 7bc9674.
github-actions
Bot
added
the
area-networking
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the earlier change that forwarded HttpContext.RequestAborted into DefaultProblemDetailsWriter.WriteAsync()’s WriteAsJsonAsync(...) call, restoring the previous cancellation/exception behavior for problem details responses.
Changes:
- Remove
cancellationToken: httpContext.RequestAbortedfromDefaultProblemDetailsWriter.WriteAsync(). - Remove the unit test that asserted
WriteAsyncthrows when cancellation is already requested.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs | Reverts passing RequestAborted into WriteAsJsonAsync, restoring prior cancellation/throw behavior. |
| src/Http/Http.Extensions/test/ProblemDetailsDefaultWriterTest.cs | Removes the cancellation-focused regression test added for the reverted behavior. |
Open
3 tasks
BrennanConroy
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #66606
See post-merge discussions of initial PR #66606 (comment)