Avoid JSRuntime cancellation race with EndInvokeJS#66834
Open
alirezafzali wants to merge 5 commits into
Open
Conversation
1 task
Author
|
@dotnet-policy-service agree |
Open
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid JSRuntime cancellation race with EndInvokeJS
Summary of the changes
Avoid race between JSRuntime cancellation and EndInvokeJS
Description
This change fixes a race condition in
Microsoft.JSInterop.JSRuntimewhere both the cancellation callback andEndInvokeJScould concurrently attempt to complete the sameTaskCompletionSource.The issue was reported in dotnet/maui because the visible crash occurs in BlazorWebView, but the underlying race condition exists in
Microsoft.JSInterop.JSRuntimewithin aspnetcore.Previously, the cancellation callback captured the local
TaskCompletionSourcedirectly and calledTrySetCanceled, whileEndInvokeJScould simultaneously remove the same task from_pendingTasksand attempt to complete it viaSetResultorSetException. In some cases this resulted in double-completion and an unhandled exception.This change updates the cancellation path to first atomically remove the task from
_pendingTasksusingTryRemove. Only the code path that successfully removes the task is allowed to complete it.Additionally, the
EndInvokeJSexception handling path was hardened to use non-throwing completion semantics.Regression tests were added to verify:
EndInvokeJSEndInvokeJSfollowed by cancellationEndInvokeJSfollowed by cancellationFixes dotnet/maui#31943