Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mono (2019-12-13) #1958

Merged
merged 2 commits into from Dec 13, 2019
Merged

Update mono (2019-12-13) #1958

merged 2 commits into from Dec 13, 2019

Conversation

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Dec 13, 2019

Updates Mono to a build that hopefully includes the new client websocket support.

Instead of doing the upgrade manually, I've finally added a script that does it, plus updated the instructions to describe the process of using that script. @javiercn @pranavkm Could you please check these instructions and let me know if you think this is sufficient for someone other than me to do a future upgrade? I don't mind doing it, but it's better if the whole team is enabled to do so.

@SteveSandersonMS SteveSandersonMS requested review from pranavkm and javiercn Dec 13, 2019
@javiercn

This comment has been minimized.

Copy link
Contributor

javiercn commented Dec 13, 2019

Looks great!

@SteveSandersonMS SteveSandersonMS merged commit 98db22d into master Dec 13, 2019
2 checks passed
2 checks passed
Blazor-ci #20191213.1 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@SteveSandersonMS SteveSandersonMS deleted the stevesa/update-mono-2019-12-13 branch Dec 13, 2019
@SteveSandersonMS

This comment has been minimized.

Copy link
Member Author

SteveSandersonMS commented Dec 13, 2019

I checked, and the app sizes and perf numbers are more or less the same as before.

However, with this build, System.Net.WebSockets.ClientWebSocket now just works (at least in the "hello world" scenario I tried)! Great job, @kjpou1 👍

@anurse Now this is merged here, the change will propagate to the blazor-wasm branch of the aspnetcore repo within the next day or so. Do you or your team want to re-try the SignalR client at that point? Ideally, the form this would take is adding some new E2E test cases that make use of the SignalR client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.