Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop wiping HttpClientHandler #1960

Merged
merged 1 commit into from Jan 3, 2020
Merged

Stop wiping HttpClientHandler #1960

merged 1 commit into from Jan 3, 2020

Conversation

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Jan 2, 2020

Context: in the build process for Microsoft.AspNetCore.Blazor.Mono, we have an optimization step that "wipes" (i.e., replaces with a single throw instruction) specified methods from the Mono BCL. Historically this allowed us to disconnect large pieces of the BCL from the linker-rooted parts so the resulting apps were much smaller. We used this on System.Net.Http.HttpClientHandler because historically it could not be used (you had to use a different WASM-specific HttpClientHandler) and it pulled in large amounts of code from ServicePointManager and so on.

However, we no longer need to wipe HttpClientHandler (because it no longer references large dependencies in the current Mono BCL) and we don't want to (because you actually can use it now - it now works with WebAssembly by default). Additionally, it's really valuable to stop wiping it, because doing so is breaking the gRPC-Web prototype.

Technically after this PR we no longer use the wiping infrastructure at all. Eventually we might want to remove it, but I don't want to do so immediately because we haven't finished our size-optimization investigations yet, and they may well want to use this.

@SteveSandersonMS SteveSandersonMS requested a review from pranavkm Jan 2, 2020
@SteveSandersonMS

This comment has been minimized.

Copy link
Member Author

SteveSandersonMS commented Jan 2, 2020

BTW I checked and this change doesn't result in the default app size growing. And it does result in gRPC-Web working.

@JamesNK
JamesNK approved these changes Jan 3, 2020
@SteveSandersonMS SteveSandersonMS merged commit 237612e into master Jan 3, 2020
2 checks passed
2 checks passed
Blazor-ci Build #20200102.1 succeeded with issues
Details
license/cla All CLA requirements met.
@SteveSandersonMS SteveSandersonMS deleted the stevesa/stop-wiping branch Jan 3, 2020
@rynowak

This comment has been minimized.

Copy link
Member

rynowak commented Jan 7, 2020

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.