This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Stop wiping HttpClientHandler #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW I checked and this change doesn't result in the default app size growing. And it does result in gRPC-Web working. |
JamesNK
approved these changes
Jan 3, 2020
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: in the build process for
Microsoft.AspNetCore.Blazor.Mono, we have an optimization step that "wipes" (i.e., replaces with a singlethrowinstruction) specified methods from the Mono BCL. Historically this allowed us to disconnect large pieces of the BCL from the linker-rooted parts so the resulting apps were much smaller. We used this onSystem.Net.Http.HttpClientHandlerbecause historically it could not be used (you had to use a different WASM-specificHttpClientHandler) and it pulled in large amounts of code fromServicePointManagerand so on.However, we no longer need to wipe
HttpClientHandler(because it no longer references large dependencies in the current Mono BCL) and we don't want to (because you actually can use it now - it now works with WebAssembly by default). Additionally, it's really valuable to stop wiping it, because doing so is breaking the gRPC-Web prototype.Technically after this PR we no longer use the wiping infrastructure at all. Eventually we might want to remove it, but I don't want to do so immediately because we haven't finished our size-optimization investigations yet, and they may well want to use this.