Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Mono binaries to c32414966c7 #1966

Merged
merged 1 commit into from Jan 16, 2020
Merged

Conversation

@mkArtakMSFT
Copy link
Contributor

mkArtakMSFT commented Jan 14, 2020

Also updated the Upgrade script to use the new dotnat.wasm and dotnet.js names instead of mono.wasm and mono.js respectively.

Addresses dotnet/aspnetcore#18316

@mkArtakMSFT

This comment has been minimized.

Copy link
Contributor Author

mkArtakMSFT commented Jan 14, 2020

I'm not going to merge this yet, as need to still validate these changes. However, @SteveSandersonMS and @pranavkm, I'm thinking about the rename from 'mono.wasm' to dotnet.wasm. Do we also need to react to that change somewhere?

@SteveSandersonMS

This comment has been minimized.

Copy link
Member

SteveSandersonMS commented Jan 14, 2020

Do we also need to react to that change somewhere?

Definitely. Probably in several places. I’d start by searching through all the sources in the Components dir in the aspnetcore repo. I’m happy to help track this down.

@mkArtakMSFT

This comment has been minimized.

Copy link
Contributor Author

mkArtakMSFT commented Jan 14, 2020

Here is the reaction: dotnet/aspnetcore#18345

@s4lish

This comment was marked as off-topic.

Copy link

s4lish commented Jan 15, 2020

it's very nice and clean if we can write @if and @for or @foreach inside HTML Elements looks like Angular or Vue.js.

@mkArtakMSFT mkArtakMSFT merged commit 84d82f6 into master Jan 16, 2020
3 checks passed
3 checks passed
WIP Ready for review
Details
blazor-ci Build #20200114.1 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT/monoUpgrade branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.