Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version numbers in dotnet.js pack output #1985

Merged
merged 3 commits into from Mar 3, 2020
Merged

Use version numbers in dotnet.js pack output #1985

merged 3 commits into from Mar 3, 2020

Conversation

@pranavkm
Copy link
Contributor

pranavkm commented Mar 2, 2020

No description provided.

@pranavkm pranavkm requested a review from SteveSandersonMS Mar 2, 2020
@pranavkm

This comment has been minimized.

Copy link
Contributor Author

pranavkm commented Mar 2, 2020

image

While this means you get different stamps between different builds even if the content is identical, I don't think that's particularly problematic. Especially once Blazor RTMs.

Copy link
Member

SteveSandersonMS left a comment

Looks good!

It's possible that some "reaction" update will also be need in the aspnetcore repo. I tried to make it accept any dotnet.*.js file but don't remember if this covered absolutely everything. Update: At minimum, this can be removed and this can be simplified, since we no longer need two separate _BlazorOutputWithTargetPath items - we can reduce it to a single one that combines @(_DotNetWasmRuntimeFile) and @(_DotNetWasmJsFile).

I have a slight preference for the filename format looking more like our assembly filenames, e.g., dotnet.3.2.0-suffix.js. It seems you're explicitly replacing . with _ but I'm unsure why.

@pranavkm

This comment has been minimized.

Copy link
Contributor Author

pranavkm commented Mar 3, 2020

I have a slight preference for the filename format looking more like our assembly filenames, e.g., dotnet.3.2.0-suffix.js

Ok. I'd assumed Blazor would be confused if it saw multiple "dots" in the filename. Should be trivial to change it to use the original file name as is.

pranavkm added 2 commits Mar 3, 2020
@pranavkm

This comment has been minimized.

Copy link
Contributor Author

pranavkm commented Mar 3, 2020

Removed the transformation. We can figure out if the client needs to be updated in the integration PR.

@pranavkm pranavkm merged commit 0106491 into master Mar 3, 2020
3 checks passed
3 checks passed
WIP Ready for review
Details
blazor-ci Build #20200303.2 succeeded with issues
Details
license/cla All CLA requirements met.
Details
@pranavkm pranavkm deleted the prkrishn/versions branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.