Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete DELETEME.md #1987

Merged
merged 1 commit into from Mar 3, 2020
Merged

Delete DELETEME.md #1987

merged 1 commit into from Mar 3, 2020

Conversation

@anurse
Copy link
Contributor

anurse commented Mar 3, 2020

I was hoping to beat the auto-merge but I failed :(

@anurse anurse added the auto-merge label Mar 3, 2020
@msftbot

This comment has been minimized.

Copy link
Contributor

msftbot bot commented Mar 3, 2020

Hello @anurse!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
@anurse anurse requested a review from pranavkm Mar 3, 2020
@msftbot msftbot bot merged commit 6620697 into master Mar 3, 2020
3 checks passed
3 checks passed
WIP Ready for review
Details
blazor-ci Build #20200303.5 succeeded with issues
Details
license/cla All CLA requirements met.
@msftbot msftbot bot deleted the anurse/undo-test-page branch Mar 3, 2020
@anurse

This comment has been minimized.

Copy link
Contributor Author

anurse commented Mar 3, 2020

@pranavkm do we want auto-merge to be immediate like this? In dotnet/aspnetcore we require that the PR be open for at least 60 minutes (just to make sure someone is able to look at it). I notice we don't require review approvals here, but given the automated nature of this, that seems OK. Note that it is possible to have the msftbot give review approval for a PR, so we could require approval for PRs in general but exempt any automation from that process (that's what we do in dotnet/aspnetcore).

@pranavkm

This comment has been minimized.

Copy link
Contributor

pranavkm commented Mar 3, 2020

Yeah, that should be fine. We're gating the changes in the dependency update PR in to dotnet/aspnetcore. There's really nothing interesting for us to vet in the automated PRs we have in this repo.

@pranavkm

This comment has been minimized.

Copy link
Contributor

pranavkm commented Mar 3, 2020

Also thanks for setting this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.