From 28ebbb9f08d53e0da96be6cdfbdf64a9c8a66556 Mon Sep 17 00:00:00 2001 From: Paulo Janotti Date: Fri, 22 Jun 2018 09:27:52 -0700 Subject: [PATCH 1/3] Initial change for adding coverage runtime folder --- .../PackageFiles/CodeCoverage.targets | 37 ++++++++++++++++++- .../xunit.console.netcore.runtimeconfig.json | 8 ++++ .../PackageFiles/tests.targets | 13 ++++++- 3 files changed, 56 insertions(+), 2 deletions(-) create mode 100644 src/Microsoft.DotNet.Build.Tasks/PackageFiles/coverage/xunit.console.netcore.runtimeconfig.json diff --git a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets index 1ad9d08e01..32779b6f86 100644 --- a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets +++ b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets @@ -17,6 +17,7 @@ $(TestWorkingDir)coverage\ true + true false @@ -53,7 +54,9 @@ - + + + + $(TestHostRootPath)shared/Microsoft.NETCore.App/10.10.10 + + + + + + + + + + + + + + $(PackagesDir)OpenCover\$(OpenCoverVersion)\tools\OpenCover.Console.exe diff --git a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/coverage/xunit.console.netcore.runtimeconfig.json b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/coverage/xunit.console.netcore.runtimeconfig.json new file mode 100644 index 0000000000..2f2aa2dab5 --- /dev/null +++ b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/coverage/xunit.console.netcore.runtimeconfig.json @@ -0,0 +1,8 @@ +{ + "runtimeOptions": { + "framework": { + "name": "Microsoft.NETCore.App", + "version": "10.10.10" + } + } +} \ No newline at end of file diff --git a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets index a86d2c28bf..c2c5a5a329 100644 --- a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets +++ b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets @@ -35,7 +35,6 @@ - $(ToolsDir)\xunit.console.netcore.runtimeconfig.json %RUNTIME_PATH%\ $RUNTIME_PATH/ $(TestRuntimeEnvVar)dotnet.exe @@ -96,6 +95,18 @@ + + + + $(ToolsDir)coverage/xunit.console.netcore.runtimeconfig.json + + + + + $(ToolsDir)xunit.console.netcore.runtimeconfig.json + + + From 03164309c9f9bee4a79133e5f445529b65371ce6 Mon Sep 17 00:00:00 2001 From: Paulo Janotti Date: Fri, 22 Jun 2018 10:04:02 -0700 Subject: [PATCH 2/3] Remove IL pdb copying --- .../PackageFiles/CodeCoverage.targets | 50 ------------------- 1 file changed, 50 deletions(-) diff --git a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets index 32779b6f86..6be842f825 100644 --- a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets +++ b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets @@ -16,7 +16,6 @@ true $(TestWorkingDir)coverage\ - true true @@ -53,48 +52,6 @@ - - - - - - $(NETCoreAppTestSharedFrameworkPath)%(Identity).pdb - - - - - - - - - - - - - - - - - - - - - - - - - - - - - From d2106c5649fafe9f3865ea8c5280f64b7110d522 Mon Sep 17 00:00:00 2001 From: Paulo Janotti Date: Thu, 28 Jun 2018 13:55:45 -0700 Subject: [PATCH 3/3] PR feedback + no hardlink for dedicated runtime --- .../PackageFiles/CodeCoverage.targets | 78 ++++++++++--------- .../PackageFiles/tests.targets | 16 +++- 2 files changed, 56 insertions(+), 38 deletions(-) diff --git a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets index 6be842f825..0dbc35e62f 100644 --- a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets +++ b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/CodeCoverage.targets @@ -17,7 +17,8 @@ $(TestWorkingDir)coverage\ true - + $(TestHostRootPath)shared/Microsoft.NETCore.App/10.10.10 + false false @@ -52,11 +53,50 @@ + + + + + <_RuntimeFiles Include="$(NETCoreAppTestSharedFrameworkPath)/*.*" /> + + + + + + + + + + + + + + $(CoverageDedicatedRuntimeDir) + + + + + $(NETCoreAppTestSharedFrameworkPath) + + + + @@ -64,7 +104,7 @@ - + - + - - - $(TestHostRootPath)shared/Microsoft.NETCore.App/10.10.10 - - - - - - - - - - - - - - $(PackagesDir)OpenCover\$(OpenCoverVersion)\tools\OpenCover.Console.exe diff --git a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets index c2c5a5a329..11004f3647 100644 --- a/src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets +++ b/src/Microsoft.DotNet.Build.Tasks/PackageFiles/tests.targets @@ -41,6 +41,7 @@ $(TestRuntimeEnvVar)dotnet xunit.console.netcore.exe + xunit.console.netcore.runtimeconfig.json {2E36F1D4-B23C-435D-AB41-18E608940038} @@ -98,12 +99,14 @@ - $(ToolsDir)coverage/xunit.console.netcore.runtimeconfig.json + $(ToolsDir)coverage/$(XunitRuntimeConfigFile) + true - $(ToolsDir)xunit.console.netcore.runtimeconfig.json + $(ToolsDir)$(XunitRuntimeConfigFile) + false @@ -125,7 +128,14 @@ - + + + +