New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet crossgen support #1437

Open
gkhanna79 opened this Issue Feb 16, 2016 · 10 comments

Comments

Projects
None yet
@gkhanna79
Copy link
Member

gkhanna79 commented Feb 16, 2016

The "dotnet" command infrastructure should provision for allowing the user to crossgen the compiled binary or output of publish.

@gkhanna79 gkhanna79 added the commands label Feb 16, 2016

@gkhanna79 gkhanna79 added this to the RTM-March milestone Feb 16, 2016

@davidfowl

This comment has been minimized.

Copy link
Collaborator

davidfowl commented Feb 16, 2016

I have a PR for this as part of publish but it needs some love

@gkhanna79

This comment has been minimized.

Copy link
Member

gkhanna79 commented Feb 16, 2016

Thanks @davidfowl. Please keep @JohnChen0, @jkotas and me in loop of the PR.

@TheRealPiotrP TheRealPiotrP modified the milestones: Backlog, 1.0.0-rtm Dec 7, 2016

@Petermarcu

This comment has been minimized.

Copy link
Member

Petermarcu commented Oct 16, 2017

@davidfowl did you ever finish the PR?

@Petermarcu

This comment has been minimized.

Copy link
Member

Petermarcu commented Oct 16, 2017

Moving this into 2.1 so it isn't lost. This request has come up many many times. Let's see what we can do.

@agocke

This comment has been minimized.

Copy link
Collaborator

agocke commented Nov 15, 2017

I'll second this. It's very difficult to both find the list of assemblies we need for shared libraries and find the proper crossgen.exe.

@steveharter steveharter modified the milestone: 2.2.0 Jan 10, 2018

@tmds

This comment has been minimized.

Copy link
Member

tmds commented Jan 29, 2018

This feature is definitely interesting for serverless. A process doesn't live long, it is launched for each function invocation. So the cost of JIT can be high compared to the actual work being done.

@jkotas

This comment has been minimized.

Copy link
Member

jkotas commented Jan 29, 2018

dotnet/sdk#593 is duplicate. Does this feature request belong to SDK or CLI repos? I would think that it should be SDK.

BTW: SDK has a bunch of crossgen plumbing already: https://github.com/dotnet/sdk/blob/master/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.CrossGen.targets . It is used by dotnet store https://docs.microsoft.com/en-us/dotnet/core/deploying/runtime-store feature.

@livarcocc

This comment has been minimized.

Copy link
Member

livarcocc commented Jan 29, 2018

This belongs here in the CLI. The SDK repo will be merged with the CLI repo in the medium feature. Having said that, this did not make the 2.1 timeline. As such, I am moving it to the backlog.

@livarcocc livarcocc modified the milestones: 2.1.3xx, Backlog Jan 29, 2018

@dasMulli

This comment has been minimized.

Copy link
Contributor

dasMulli commented Jan 29, 2018

There may be two separate concerns here:

  1. Have a dotnet crossgen command (global tool?) that can be used on any assembly. Could be run on portable applications as part of a deployment process on a target server (so the r2r assemblies match the current version of the runtime).
  2. Crossgen on publish(/build) as part of the build process.
@sbomer

This comment has been minimized.

Copy link
Member

sbomer commented Jan 30, 2018

mono/linker has the ability to run crossgen during publish: mono/linker#192. This could probably be used as a starting point. dotnet/sdk#1814 may also be relevant whenever this is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment