Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Localized satellite packages are incorrectly marked as incompatible by the CLI #3396
Steps to reproduce
Create a console application and add a reference to
Restore completes successfully.
CLI states that the satellite packages aren't compatible with netcoreapp1.0
We have a check but it's out of date. It would be great if we could call into something, even if it wasn't a good API. The cli and nuget ship in the same app so it's impossible to update nuget outside of the cli (as a cli user) so the risk of breaking is low
referenced this issue
Jun 6, 2016
Restore succeeds and always writes the lock file (regardless of failure). Build and the project model server want to show the same errors that restore showed. To do that, it tries to repeat the compatibility check to make sure things got resolved.
That's the entire purpose of this request. The errors need to be persisted in some format, preferably the lock file since that's what we use for everything else.
added a commit
Jul 4, 2016
Good news :)
I just tried this with CLI RC3 bits and successfully added Humanizer to a project. Caveats, of course, but solvable by Humanizer itself!
The above was a successful. I hope @onovotny can take a look and confirm!