New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet tool list --local #10426

Merged
merged 5 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@wli3
Collaborator

wli3 commented Dec 4, 2018

There are several renames, please review by commit.

17:21 $ dotnet tool list
Package Id            Version      Commands             Manifest
----------------------------------------------------------------------------------------------------------------------
dotnet-dbinfo         1.3.1        dotnet-dbinfo        /Users/williamli/Documents/temp/temp/sub/dotnet-tools.json
dotnet-depends        0.2.0        dotnet-depends       /Users/williamli/Documents/temp/temp/sub/dotnet-tools.json
amazon.ecs.tools      3.0.0        dotnet-ecs           /Users/williamli/Documents/temp/temp/sub/dotnet-tools.json
dotnet-encrypto       1.0.5        dotnet-encrypto      /Users/williamli/Documents/temp/temp/sub/dotnet-tools.json
t-rex                 1.0.53       t-rex                /Users/williamli/Documents/temp/temp/.config/dotnet-tools.json

@wli3 wli3 added the tool label Dec 4, 2018

@wli3 wli3 added this to the 3.0.1xx milestone Dec 4, 2018

@wli3 wli3 self-assigned this Dec 4, 2018

@wli3 wli3 requested review from dsplaisted, peterhuene and dotnet/dotnet-cli Dec 4, 2018

<data name="InvalidToolPathOption" xml:space="preserve">
<value>Tool path '{0}' does not exist.</value>
</data>
<data name="LocalOptionDescription" xml:space="preserve">
<value>List the tools installed in the local tool manifest.</value>
</data>
<data name="ListToolCommandInvalidGlobalAndLocalAndToolPath" xml:space="preserve">
<value>The local option(--local), the global option (--global), the tool path option (--tool-path), can only have one at a time. Please specify only one of the options: {0}.</value>

This comment has been minimized.

@livarcocc

livarcocc Dec 4, 2018

Member

This text needs review.

cc @KathleenDollard

This comment has been minimized.

@wli3

wli3 Dec 5, 2018

Collaborator

I will double check with her when she is back. although the text is basically the same as install which is reviewed

? new[] {(filePath.Value, filePath.Value.GetDirectoryPath())}
: EnumerateDefaultAllPossibleManifests();

TryFindToolManifestPackages(allPossibleManifests, out var toolManifestPackageAndSource);

This comment has been minimized.

@livarcocc

livarcocc Dec 4, 2018

Member

Should you have some condition here for the case where this fails? Given that it is a Try... method?

This comment has been minimized.

@wli3

wli3 Dec 5, 2018

Collaborator

fixed, added false case. it happens to work since toolManifestPackageAndSource will not be null but empty array when returns false.

@wli3 wli3 force-pushed the wli3:local-tools-list2 branch from 2f260f7 to 6ca8d76 Dec 5, 2018

@wli3 wli3 merged commit 0981fb3 into dotnet:master Dec 5, 2018

2 checks passed

.NET Core CLI CI #20181205.5 succeeded
Details
license/cla All CLA requirements met.
Details

@wli3 wli3 deleted the wli3:local-tools-list2 branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment