Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke localtool with dotnet #10980

Merged
merged 5 commits into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@wli3
Copy link
Collaborator

wli3 commented Mar 15, 2019

enable invoke tool with dotnet TOOLNAME

largely bring back the code from #10341 but still keep dotnet tool run TOOLNAME as non ambiguous version

@wli3 wli3 assigned peterhuene and unassigned peterhuene Mar 15, 2019

@@ -161,7 +161,7 @@
Tool '{1}' (version '{2}') was successfully installed.</value>
</data>
<data name="LocalToolInstallationSucceeded" xml:space="preserve">
<value>You can invoke the tool from this directory using the following command: dotnet tool run {0}
<value>You can invoke the tool from this directory using the following command: dotnet tool run {0} or dotnet {0}

This comment has been minimized.

@wli3

wli3 Mar 15, 2019

Author Collaborator

@KathleenDollard I added "or dotnet {0}" to match you can both invoke it from dotnet tool run and dotnet

@wli3

This comment has been minimized.

Copy link
Collaborator Author

wli3 commented Mar 18, 2019

@dotnet/dotnet-cli for review

@peterhuene peterhuene requested review from dotnet/dotnet-cli and peterhuene Mar 18, 2019

@peterhuene
Copy link
Member

peterhuene left a comment

Looks good; just some questions and suggestions to resolve first.

peterhuene and others added some commits Mar 18, 2019

Update src/dotnet/commands/dotnet-tool/install/LocalizableStrings.resx
Co-Authored-By: wli3 <wul@microsoft.com>
@wli3

This comment has been minimized.

Copy link
Collaborator Author

wli3 commented Mar 18, 2019

@peterhuene I resolved all the issues

@wli3 wli3 merged commit 2f5c76e into dotnet:master Mar 18, 2019

2 checks passed

.NET Core CLI CI #20190318.2 succeeded
Details
license/cla All CLA requirements met.
Details

@wli3 wli3 deleted the wli3:invoke-localtool-with-dotnet branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.