Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix the help command to work with intrinsic commands. #1231
The old "dotnet help" code assumed every command is defined by a "dotnet-command" executable. However this is no longer true for intrinsic commands.
I tried this change out with both intrinsic and extrinsic commands and they now print help as expected.
I also added some tests to make sure the "dotnet help" command executes successfully.
Hi @AustinWise, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
I push a new commit wherein I moved made 'help' be a command like any other. That seems cleaner than making Cli.Program pretend a help command exists.
I assume the plan is eventually make the help command more like Git's, i.e. show a manpage on Unix and open the documentation in a browser on Windows. So while the HelpCommand class is very small now, it should be big enough to justify its existence in the future.