Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation script update #13030

Merged
merged 7 commits into from Nov 6, 2019

Conversation

@johnbeisner
Copy link
Member

johnbeisner commented Nov 5, 2019

Installation script update

Addresses: dotnet/sdk#3827

jbeisner
@johnbeisner johnbeisner requested a review from dotnet/dotnet-cli Nov 5, 2019
@johnbeisner johnbeisner self-assigned this Nov 5, 2019
@@ -255,7 +255,7 @@ check_pre_reqs() {
local librarypath=${LD_LIBRARY_PATH:-}
LDCONFIG_COMMAND="$LDCONFIG_COMMAND -NXv ${librarypath//:/ }"

[ -z "$($LDCONFIG_COMMAND 2>/dev/null | grep libunwind)" ] && say_warning "Unable to locate libunwind. Probable prerequisite missing; install libunwind."
[ -z "$($LDCONFIG_COMMAND 2>/dev/null | grep zlib)" ] && say_warning "Unable to locate zlib. Probable prerequisite missing; please install zlib."

This comment has been minimized.

Copy link
@livarcocc

livarcocc Nov 5, 2019

Member

were we missing zlib before? the warning that is.

This comment has been minimized.

Copy link
@johnbeisner

johnbeisner Nov 5, 2019

Author Member

It appears that we were missing 'zlib' before; given that these warnings appear to be the intersection of the Ubuntu, CentOS, and Fedora prerequisites.
See: https://docs.microsoft.com/en-us/dotnet/core/linux-prerequisites?tabs=netcore30#supported-linux-versions

Copy link
Member

livarcocc left a comment

I marked this approved. But shouldn't this go to dotnet/toolset?

dotnet/cli @ master is being deprecated and the dotnet/cli and dotnet/toolset (in progress) repos are going to be merged into dotnet/sdk.

@johnbeisner

This comment has been minimized.

Copy link
Member Author

johnbeisner commented Nov 5, 2019

@livarcocc
You are correct, this should go into toolset. However, there are 2 active PRs against CLI: #12880 and #12642 that I am driving to completion - we will finish up in CLI then I will merge all changes one-time into toolset instead of asking the contributors to re-target their PRs.

jbeisner added 3 commits Nov 5, 2019
jbeisner
jbeisner
jbeisner
@johnbeisner johnbeisner closed this Nov 6, 2019
@johnbeisner johnbeisner reopened this Nov 6, 2019
@nguerrera

This comment has been minimized.

Copy link
Member

nguerrera commented Nov 6, 2019

Please make sure to preserve attribution when porting to toolset

jbeisner added 3 commits Nov 6, 2019
jbeisner
jbeisner
@johnbeisner johnbeisner merged commit ba194e4 into dotnet:master Nov 6, 2019
20 checks passed
20 checks passed
.NET Core CLI CI Build #20191106.1 succeeded
Details
.NET Core CLI CI (Build Darwin Build_Release) Build Darwin Build_Release succeeded
Details
.NET Core CLI CI (Build Linux Build_CentOS_7_1_Debug_x64) Build Linux Build_CentOS_7_1_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_Debian_jessie_Debug_x64) Build Linux Build_Debian_jessie_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_Fedora_27_Debug_x64) Build Linux Build_Fedora_27_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_LinuxPortable_NoSuffix_Release_x64) Build Linux Build_LinuxPortable_NoSuffix_Release_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_LinuxPortable_Release_x64) Build Linux Build_LinuxPortable_Release_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_Linux_musl_Debug_x64) Build Linux Build_Linux_musl_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_OpenSUSE_42_3_Debug_x64) Build Linux Build_OpenSUSE_42_3_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_Rhel_6_Debug_x64) Build Linux Build_Rhel_6_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_Rhel_7_2_Release_x64) Build Linux Build_Rhel_7_2_Release_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_Ubuntu_14_04_Release_x64) Build Linux Build_Ubuntu_14_04_Release_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_Ubuntu_16_04_Debug_x64) Build Linux Build_Ubuntu_16_04_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Linux Build_Ubuntu_18_04_Debug_x64) Build Linux Build_Ubuntu_18_04_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Windows_NT Build_Debug_x86) Build Windows_NT Build_Debug_x86 succeeded
Details
.NET Core CLI CI (Build Windows_NT Build_DropSuffix_Release_x64) Build Windows_NT Build_DropSuffix_Release_x64 succeeded
Details
.NET Core CLI CI (Build Windows_NT Build_ES_Debug_x64) Build Windows_NT Build_ES_Debug_x64 succeeded
Details
.NET Core CLI CI (Build Windows_NT Build_Release_x64) Build Windows_NT Build_Release_x64 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.