From 0068fb5fdc4ba973be452862233820ae657078dd Mon Sep 17 00:00:00 2001 From: Larson Carter Date: Thu, 4 Jun 2020 09:47:27 -0500 Subject: [PATCH 1/2] Port zsh shell completion to #compdef - @mcornella I did NOT find this solution, I know @mcornella is quite busy and I wanted to make sure that this was able to be formed into a PR. This solves issue https://github.com/dotnet/sdk/issues/9232 --- scripts/register-completions.zsh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/register-completions.zsh b/scripts/register-completions.zsh index 8eebe9a867..7321c91979 100644 --- a/scripts/register-completions.zsh +++ b/scripts/register-completions.zsh @@ -2,9 +2,11 @@ _dotnet_zsh_complete() { - local completions=("$(dotnet complete "$words")") - reply=( "${(ps:\n:)completions}" ) + #compdef dotnet + local completions=("$(dotnet complete "$words")") + compadd "${(ps:\n:)completions}" + } compctl -K _dotnet_zsh_complete dotnet From 8d2858a07673fffd827ef3f60655a2d097f8ea62 Mon Sep 17 00:00:00 2001 From: Larson Carter Date: Thu, 4 Jun 2020 10:00:43 -0500 Subject: [PATCH 2/2] Remove function --- scripts/register-completions.zsh | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/scripts/register-completions.zsh b/scripts/register-completions.zsh index 7321c91979..0fb5aa673e 100644 --- a/scripts/register-completions.zsh +++ b/scripts/register-completions.zsh @@ -1,12 +1,3 @@ -# zsh parameter completion for the dotnet CLI - -_dotnet_zsh_complete() -{ - - #compdef dotnet - local completions=("$(dotnet complete "$words")") - compadd "${(ps:\n:)completions}" - -} - -compctl -K _dotnet_zsh_complete dotnet +#compdef dotnet +local completions=("$(dotnet complete "$words")") +compadd "${(ps:\n:)completions}"