New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --source-feed to --add-source #9164

Merged
merged 2 commits into from May 1, 2018

Conversation

Projects
None yet
5 participants
@wli3
Copy link
Collaborator

wli3 commented Apr 27, 2018

@wli3 wli3 force-pushed the wli3:rename-to-add-source branch from 9120085 to d51926a Apr 27, 2018

@KathleenDollard

This comment has been minimized.

Copy link

KathleenDollard commented Apr 27, 2018

LGTM

@wli3 wli3 changed the title WIP Rename to add source Rename to add source Apr 27, 2018

@wli3 wli3 requested review from peterhuene and dotnet/dotnet-cli Apr 27, 2018

@wli3

This comment has been minimized.

Copy link
Collaborator

wli3 commented Apr 27, 2018

preparing shiproom email

<data name="SourceFeedOptionName" xml:space="preserve">
<value>SOURCE_FEED</value>
<data name="AddSourceOptionName" xml:space="preserve">
<value>ADD_SOURCE</value>

This comment has been minimized.

@peterhuene

peterhuene Apr 27, 2018

Member

I think just SOURCE is fine (would show up as --add-source <SOURCE>

This comment has been minimized.

@wli3

wli3 Apr 27, 2018

Collaborator

source will be confused with restore source (exclusive)

This comment has been minimized.

@wli3

wli3 Apr 27, 2018

Collaborator

I see what you saying. Let me change to source

This comment has been minimized.

@wli3

wli3 Apr 27, 2018

Collaborator

fixed

This comment has been minimized.

@peterhuene

peterhuene Apr 27, 2018

Member

Do we need another loc update? It's now showing review needed for the option name, with ADD_SOURCE used currently for loc.

@peterhuene
Copy link
Member

peterhuene left a comment

Let's use SOURCE instead of ADD_SOURCE for the option name; it gives a cleaner command line help.

wli3 added some commits Apr 27, 2018

@wli3 wli3 force-pushed the wli3:rename-to-add-source branch from 4a80192 to 33aa705 Apr 27, 2018

@wli3 wli3 changed the title Rename to add source Rename --source-feed to --add-source Apr 27, 2018

@MattGertz

This comment has been minimized.

Copy link

MattGertz commented Apr 27, 2018

I agree; current verbiage is confusing.

@livarcocc

This comment has been minimized.

Copy link
Member

livarcocc commented Apr 30, 2018

@dotnet-bot Test CentOS7.1 x64 Debug Build

@livarcocc livarcocc added this to the 2.1.3xx milestone Apr 30, 2018

@livarcocc

This comment has been minimized.

Copy link
Member

livarcocc commented Apr 30, 2018

Marking WIP until the branches are open for RTM changes.

@livarcocc livarcocc changed the title Rename --source-feed to --add-source WIP: Rename --source-feed to --add-source Apr 30, 2018

@livarcocc livarcocc changed the title WIP: Rename --source-feed to --add-source Rename --source-feed to --add-source Apr 30, 2018

@livarcocc

This comment has been minimized.

Copy link
Member

livarcocc commented Apr 30, 2018

@dotnet-bot Test CentOS7.1 x64 Debug Build

@wli3 wli3 merged commit d681933 into dotnet:release/2.1.3xx May 1, 2018

17 checks passed

CROSS Check Build finished.
Details
CentOS7.1 x64 Debug Build Build finished.
Details
Debian8.2 x64 Debug Build Build finished.
Details
Linux arm Debug Build Build finished.
Details
Linux arm64 Debug Build Build finished.
Details
Linux x64 Release Build Build finished.
Details
Linux-musl x64 Debug Build Build finished.
Details
OSX10.12 x64 Release Build Build finished.
Details
RHEL6 x64 Debug Build Build finished.
Details
RHEL7.2 x64 Release Build Build finished.
Details
Ubuntu x64 Release Build Build finished.
Details
Ubuntu16.04 x64 Debug Build Build finished.
Details
WIP ready for review
Details
Windows_NT x64 Release Build Build finished.
Details
Windows_NT x86 Debug Build Build finished.
Details
Windows_NT_ES x64 Debug Build Build finished.
Details
license/cla All CLA requirements met.
Details

@wli3 wli3 deleted the wli3:rename-to-add-source branch May 1, 2018

@ghost ghost referenced this pull request May 2, 2018

Merged

Global tools - Part 1 #5036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment