Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set parent symbol when custom parse delegate is called on default value #777

Conversation

@jonsequitur
Copy link
Contributor

jonsequitur commented Feb 5, 2020

This replaces the dummy ArgumentResult passed to the ParseArgument<T> delegate with a correctly-parented ArgumentResult.

@Keboo
Keboo approved these changes Feb 5, 2020
@jonsequitur jonsequitur merged commit 3e225df into dotnet:master Feb 5, 2020
9 checks passed
9 checks passed
WIP Ready for review
Details
command-line-api Build #20200204.1 succeeded
Details
command-line-api (Build and Test OSX Debug) Build and Test OSX Debug succeeded
Details
command-line-api (Build and Test OSX Release) Build and Test OSX Release succeeded
Details
command-line-api (Build and Test Ubuntu 16.04 Debug) Build and Test Ubuntu 16.04 Debug succeeded
Details
command-line-api (Build and Test Ubuntu 16.04 Release) Build and Test Ubuntu 16.04 Release succeeded
Details
command-line-api (Build and Test Windows Debug) Build and Test Windows Debug succeeded
Details
command-line-api (Build and Test Windows Release) Build and Test Windows Release succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.