This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Remove file names from PackagePath folder #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are hitting NuGet/Home#6351, which was resolved as a by-design change so we need to adjust to handle it. Paths for filenames that don't have extensions turned into <filename>\<filename> as the file got appended to it. Without an extension nuget assumes the target path is a directory, for better or worse.
|
This is blocking official builds and won't get exercised in CI so merging. I will monitor official builds after this change goes through. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hitting NuGet/Home#6351, which
was resolved as a by-design change so we need to adjust to
handle it.
Paths for filenames that don't have extensions turned into
<filename> as the file got appended to it. Without
an extension nuget assumes the target path is a directory,
for better or worse.
cc @Petermarcu here is another SDK regression caused by a nuget change.