Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler: allow relative path for source directory #5594

Conversation

@AustinWise
Copy link

AustinWise commented Mar 27, 2019

Also fix a typo.

Without this change, the bundler has an internal error when a relative path is used as the source.

Also a typo.
Copy link

swaroop-sridhar left a comment

Looks good, thanks.

@AustinWise

This comment has been minimized.

Copy link
Author

AustinWise commented Mar 28, 2019

It seems like the shared framework is not building for some reason:

2019-03-28T00:01:02.2743087Z /root/coresetup/src/sharedFramework/lockedhost/lockedhost.csproj : error NU1102: Unable to find package Microsoft.NETCore.DotNetHostResolver with version (>= 3.0.0-preview4-27527-22) [/root/coresetup/src/sharedFramework/sharedFramework.proj]

@swaroop-sridhar

This comment has been minimized.

Copy link

swaroop-sridhar commented Mar 28, 2019

@dotnet-bot test this please

@swaroop-sridhar

This comment has been minimized.

@swaroop-sridhar swaroop-sridhar merged commit 3f3c14e into dotnet:master Apr 2, 2019
25 checks passed
25 checks passed
WIP Ready for review
Details
dotnet.core-setup Build #20190327.22 succeeded
Details
dotnet.core-setup (Build_Linux_Arm debug) Build_Linux_Arm debug succeeded
Details
dotnet.core-setup (Build_Linux_Arm release) Build_Linux_Arm release succeeded
Details
dotnet.core-setup (Build_Linux_Arm64 debug) Build_Linux_Arm64 debug succeeded
Details
dotnet.core-setup (Build_Linux_Arm64 release) Build_Linux_Arm64 release succeeded
Details
dotnet.core-setup (Build_Linux_Arm64_Alpine37 debug) Build_Linux_Arm64_Alpine37 debug succeeded
Details
dotnet.core-setup (Build_Linux_Arm64_Alpine37 release) Build_Linux_Arm64_Alpine37 release succeeded
Details
dotnet.core-setup (Build_Linux_x64_Alpine36 debug) Build_Linux_x64_Alpine36 debug succeeded
Details
dotnet.core-setup (Build_Linux_x64_Alpine36 release) Build_Linux_x64_Alpine36 release succeeded
Details
dotnet.core-setup (Build_Linux_x64_Rhel6 debug) Build_Linux_x64_Rhel6 debug succeeded
Details
dotnet.core-setup (Build_Linux_x64_Rhel6 release) Build_Linux_x64_Rhel6 release succeeded
Details
dotnet.core-setup (Build_Linux_x64_glibc debug) Build_Linux_x64_glibc debug succeeded
Details
dotnet.core-setup (Build_Linux_x64_glibc release) Build_Linux_x64_glibc release succeeded
Details
dotnet.core-setup (Build_OSX debug) Build_OSX debug succeeded
Details
dotnet.core-setup (Build_OSX release) Build_OSX release succeeded
Details
dotnet.core-setup (Build_Windows_Arm debug) Build_Windows_Arm debug succeeded
Details
dotnet.core-setup (Build_Windows_Arm release) Build_Windows_Arm release succeeded
Details
dotnet.core-setup (Build_Windows_Arm64 debug) Build_Windows_Arm64 debug succeeded
Details
dotnet.core-setup (Build_Windows_Arm64 release) Build_Windows_Arm64 release succeeded
Details
dotnet.core-setup (Build_Windows_x64 debug) Build_Windows_x64 debug succeeded
Details
dotnet.core-setup (Build_Windows_x64 release) Build_Windows_x64 release succeeded
Details
dotnet.core-setup (Build_Windows_x86 debug) Build_Windows_x86 debug succeeded
Details
dotnet.core-setup (Build_Windows_x86 release) Build_Windows_x86 release succeeded
Details
license/cla All CLA requirements met.
Details
@AustinWise

This comment has been minimized.

Copy link
Author

AustinWise commented Apr 2, 2019

@swaroop-sridhar That's a good point about the test case, I'll try to make a follow up PR when I get some time.

@swaroop-sridhar

This comment has been minimized.

Copy link

swaroop-sridhar commented Apr 2, 2019

Thanks @AustinWise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.