Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate dotnet.bootstrap.py #1063

Merged
merged 8 commits into from Nov 9, 2017
Merged

Deprecate dotnet.bootstrap.py #1063

merged 8 commits into from Nov 9, 2017

Conversation

sunandabalu
Copy link
Member

@sunandabalu
Copy link
Member Author

sunandabalu commented Nov 7, 2017 •
edited

@chcosta @Petermarcu

chcosta
chcosta reviewed Nov 7, 2017
View reviewed changes
tools/dotnet-bootstrap/README.md Outdated

### OVERVIEW
After you run the dotnet.bootstrap, you'll see a directory named after the Runtime Identifier (RID) next to the script, the directory tree looks like this (for example),
dotnet.bootstrap.py has been deprecated. The replacement script for .NET CLI Bootstrapping can be found here - https://github.com/dotnet/source-build/tree/dev/release/2.0/scripts/bootstrap.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Petermarcu
Copy link
Member

Seems fine to me. Will be just close the issues that are open against this script then as well?

chcosta
chcosta reviewed Nov 8, 2017
View reviewed changes
tools/dotnet-bootstrap/README.md Outdated
dotnet.bootstrap.py has been deprecated. The documentation on how to use the new replacement script for .NET CLI Bootstrapping and where it can be found is defined here - https://github.com/dotnet/source-build/blob/dev/release/2.0/Documentation/boostrap-new-os.md.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

chcosta
chcosta previously approved these changes Nov 8, 2017
View reviewed changes
@richlander
Copy link
Member

LGTM

This was referenced Nov 8, 2017
Closed
Closed
chcosta
chcosta reviewed Nov 8, 2017
View reviewed changes
netci.groovy Outdated
@@ -27,8 +27,8 @@ def branch = GithubBranchName
// shell (for unix scripting)
shell("ls")

shell("python tools/dotnet-bootstrap/base/lab/containers.py bake")

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@chcosta chcosta dismissed their stale review November 8, 2017 23:07

CI failures

@Petermarcu Petermarcu merged commit accafb6 into dotnet:master Nov 9, 2017
@sunandabalu sunandabalu deleted the depBootstrapPy branch November 9, 2017 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Petermarcu Petermarcu Petermarcu left review comments

@chcosta chcosta chcosta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sunandabalu @Petermarcu @richlander @chcosta