Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify number parsing/formatting code with corert #8793

Closed
stephentoub opened this issue Aug 23, 2017 · 4 comments
Closed

Unify number parsing/formatting code with corert #8793

stephentoub opened this issue Aug 23, 2017 · 4 comments
Labels
area-Meta help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@stephentoub
Copy link
Member

The implementation of number parsing/formatting in corert is a managed port of the native implementation in coreclr. We want to unify on the managed implementation, though doing so also involves addressing several perf gaps. Doing this will then enable much more easily implementing span-based number formatting in coreclr.

@stephentoub stephentoub self-assigned this Aug 23, 2017
@stephentoub stephentoub removed their assignment Sep 8, 2017
@stephentoub
Copy link
Member Author

The remaining code to be unified is that for double/single and decimal.

@RussKeldorph
Copy link
Contributor

@danmosemsft Is this still destined for 2.1?

@danmoseley
Copy link
Member

Nope.

@pentp
Copy link
Contributor

pentp commented Sep 22, 2018

Number parsing/formatting should be unified after dotnet/coreclr#20080 is mirrored to CoreRT (this issue can be closed).

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@msftbot msftbot bot locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

6 participants